-
Notifications
You must be signed in to change notification settings - Fork 4.4k
changing rocm
or alpaka-rocm
tools does not cause the recompilation of alpaka modules
#48054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
assign core |
New categories assigned: core @Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cms-bot internal usage |
A new Issue was created by @fwyzard. @Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
thanks @fwyzard for reporting this. This happens as the extra alpaka backend products are not directly registered in the SCRAM caches (which are used by the script tracking the external tools deps) and instead directly dumped int he Makefile fragments. I will update build rules to also add |
@smuzaffar With cms-sw/cmsdist#9861 can we close the issue? |
@fwyzard , with new build rules (in latest 15.1.X IB) , changing Can you please try thsi for [a]
|
Mhm, I just tried but I got a weird error:
|
It does work for a smaller change, like changing the CUDA architecture to build for. |
as |
That seems to be the cost of placing Alpaka-based data formats into existing packages (such as |
@fwyzard , hopefull cms-sw/cmssw-config@ab46158 should fix this. Can you please try getting https://raw.githubusercontent.com/cms-sw/cmssw-config/refs/heads/scramv3/SCRAM/GMake/Makefile.checkdeps and copy it in your |
Yes, this also works for |
Should we consider moving them to separate directories ? |
From dependency management point of view that would be a good move. |
I would expect that modifying the
rocm
andalpaka-rocm
tools and then runningscram b checkdeps
would cause all alpaka-based modules to be checked out.Instead, only the modules that use
rocm
explicitly are checked out:The text was updated successfully, but these errors were encountered: