fix: #19 - Fix detection of Retry-After header in ServerResponseException class and phpdoc

Fixes: #19

Author: williamdes

phpstan-baseline.neon

@@ -95,11 +95,6 @@ parameters:
 			count: 1
 			path: src/Response/DownstreamResponseContract.php
 
-		-
-			message: "#^Property LaravelFCM\\\\Response\\\\Exceptions\\\\ServerResponseException\\:\\:\\$retryAfter \\(int\\) does not accept array\\<string\\>\\.$#"
-			count: 1
-			path: src/Response/Exceptions/ServerResponseException.php
-
 		-
 			message: "#^Negated boolean expression is always true\\.$#"
 			count: 1

src/Response/Exceptions/ServerResponseException.php

@@ -8,9 +8,10 @@
 class ServerResponseException extends Exception
 {
     /**
-     * retry after.
+     * The value of the first Retry-After header in the response.
      *
-     * @var int
+     * @see https://httpwg.org/specs/rfc7231.html#header.retry-after
+     * @var int|string
      */
     public $retryAfter;
 
@@ -25,8 +26,9 @@ public function __construct(ResponseInterface $response)
         $responseHeader = $response->getHeaders();
         $responseBody = $response->getBody()->getContents();
 
-        if (array_keys($responseHeader, 'Retry-After')) {
-            $this->retryAfter = $responseHeader['Retry-After'];
+        if (array_key_exists('Retry-After', $responseHeader)) {
+            $retryAfterValue = $responseHeader['Retry-After'][0];
+            $this->retryAfter = is_numeric($retryAfterValue) ? (int) $retryAfterValue : $retryAfterValue;
         }
 
         parent::__construct($responseBody, $code);

tests/ServerResponseExceptionTest.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace LaravelFCM\Tests;
+
+use LaravelFCM\Response\Exceptions\ServerResponseException;
+
+class ServerResponseExceptionTest extends FCMTestCase
+{
+
+    public function testHandleWithoutRetryAfter(): void
+    {
+        $response = new \GuzzleHttp\Psr7\Response(
+            200,
+            [],
+            ''
+        );
+        $sre = new ServerResponseException($response);
+        $this->assertNull($sre->retryAfter);
+    }
+
+    public function testHandleWithRetryAfter(): void
+    {
+        $response = new \GuzzleHttp\Psr7\Response(
+            200,
+            [
+                // See: https://httpwg.org/specs/rfc7231.html#header.retry-after
+                'Retry-After' => 120,
+            ],
+            ''
+        );
+        $sre = new ServerResponseException($response);
+        $this->assertNotNull($sre->retryAfter);
+        $this->assertIsNumeric($sre->retryAfter);
+        $this->assertSame(120, $sre->retryAfter);
+    }
+
+    public function testHandleWithRetryAfterMultiple(): void
+    {
+        $response = new \GuzzleHttp\Psr7\Response(
+            200,
+            [
+                // See: https://httpwg.org/specs/rfc7231.html#header.retry-after
+                'Retry-After' => [120, 'Fri, 31 Dec 1999 23:59:59 GMT', 420],
+            ],
+            ''
+        );
+        $sre = new ServerResponseException($response);
+        $this->assertNotNull($sre->retryAfter);
+        $this->assertIsNumeric($sre->retryAfter);
+        $this->assertSame(120, $sre->retryAfter);
+    }
+}