Merge pull request #509 from com-pas/feat/508-add-find-by-name-to-doi-service

feat: added find by name to doi service, closes #508

Author: samirromdhani

sct-commons/src/main/java/org/lfenergy/compas/sct/commons/DoiService.java

@@ -25,4 +25,8 @@ public Optional<TDOI> findDoi(TAnyLN tAnyLN, Predicate<TDOI> tdoiPredicate) {
         return getFilteredDois(tAnyLN, tdoiPredicate).findFirst();
     }
 
+    public Optional<TDOI> findDoiByName(TAnyLN tAnyLN, String doiName) {
+        return findDoi(tAnyLN, tdoi -> tdoi.getName().equals(doiName));
+    }
+
 }

sct-commons/src/test/java/org/lfenergy/compas/sct/commons/DoiServiceTest.java

@@ -23,7 +23,7 @@ class DoiServiceTest {
     void getDois() {
         //Given
         SCL std = SclTestMarshaller.getSCLFromFile("/std/std_sample.std");
-        LN0 ln0 = std.getIED().get(0).getAccessPoint().get(0).getServer().getLDevice().get(0).getLN0();
+        LN0 ln0 = std.getIED().getFirst().getAccessPoint().getFirst().getServer().getLDevice().getFirst().getLN0();
 
         //When
         List<TDOI> tdois = doiService.getDois(ln0).toList();
@@ -39,7 +39,7 @@ void getDois() {
     void getFilteredDois() {
         //Given
         SCL std = SclTestMarshaller.getSCLFromFile("/std/std_sample.std");
-        LN0 ln0 = std.getIED().get(0).getAccessPoint().get(0).getServer().getLDevice().get(0).getLN0();
+        LN0 ln0 = std.getIED().getFirst().getAccessPoint().getFirst().getServer().getLDevice().getFirst().getLN0();
 
         //When
         List<TDOI> tdois = doiService.getFilteredDois(ln0, tdoi -> tdoi.getName().equals("Beh")).toList();
@@ -55,7 +55,7 @@ void getFilteredDois() {
     void findDoi() {
         //Given
         SCL std = SclTestMarshaller.getSCLFromFile("/std/std_sample.std");
-        LN0 ln0 = std.getIED().get(0).getAccessPoint().get(0).getServer().getLDevice().get(0).getLN0();
+        LN0 ln0 = std.getIED().getFirst().getAccessPoint().getFirst().getServer().getLDevice().getFirst().getLN0();
 
         //When
         Optional<TDOI> doi = doiService.findDoi(ln0, tdoi -> tdoi.getName().equals("Beh"));
@@ -65,4 +65,17 @@ void findDoi() {
                 .extracting(TDOI::getName, tdoi -> tdoi.getSDIOrDAI().size())
                 .containsExactly("Beh", 1);
     }
+
+    @Test
+    void findDoiByName() {
+        //Given
+        SCL std = SclTestMarshaller.getSCLFromFile("/std/std_sample.std");
+        LN0 ln0 = std.getIED().getFirst().getAccessPoint().getFirst().getServer().getLDevice().getFirst().getLN0();
+
+        //When
+        Optional<TDOI> doi = doiService.findDoiByName(ln0, "Beh");
+
+        //Then
+        assertThat(doi).hasValueSatisfying(tdoi -> assertThat(tdoi.getName()).isEqualTo("Beh"));
+    }
 }