Fix one of the Android Studio warnings

[nicolas-raoul]

This task is designed as a small, useful task to onboard new users to the codebase who are unsure about what to work on.

Important

Unique constraint to this issue
Multiple pull requests from the same author will not be accepted, unless the refactoring is part of a larger piece of work

Tip

You do not need to be assigned this issue to work on it

Android Studio flags a number of warnings in the project.

If a file which contains these warnings is committed, then Android Studio will warn the author. If the warning was not introduced by the author's commit, then the author is unnecessarily slowed down by having to confirm that they did not introduce more warnings into the codebase (which inevitably leads them to disabling the warning, as they're low value).

The list of warnings can be obtained via:

• Code -> Inspect Code

The aim of this task is to introduce new contributors to the code with an 'easy' first issue to resolve.

1. Run Code -> Inspect Code on the solution (it will be slow)
2. Select one file which has warnings (under the Kotlin header is easiest.- many of the Java warnings are not flagged by the IDE)
3. Fix all the errors, warnings + weak warnings in the file, automatically if this is offered by the IDE, or manually otherwise.
4. Send us a pull request. In the pull request's title/description, do not write Fixes #5996 as it would automatically close this whole issue. Instead, write Part of issue #5996.

(Note to core team: Once this issue has been all completed, we can use CI to run Android Studio in headless mode to ensure that the codebase gets to, and stays at 0 warnings.)

[KYash03]

Hey, I worked on this. Here's my PR

Would appreciate some feedback. Thank you!

[savsch]

I worked on LocationPickerActivity.kt #6026

Would like clarification on whether renaming a package (to fix the weak warning "Package name part should not start with an uppercase") falls under the scope of this issue or not.

[nicolas-raoul]

@savsch Yes fixing package case-related warnings is in scope, thanks! 🙂

[Prinuel]

Hello, i an new here, and i will like to jump on this, but for clarity, one is expected to correct the errors in only one file?, can i correct errors in more than one file?

[nicolas-raoul]

@Prinuel Maybe do it for 1 file first, and if it goes well you can do for as many as you want. 🙂

[Prinuel]

Alrighty.... thanks

[savsch]

@nicolas-raoul this issue seems to have been closed accidentally, possibly due to being linked to #6271.