Skip to content

Fix discovery of only the last test in equally named suites #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ILikeRubberDuckies
Copy link

resolves #65

@connor4312
Copy link
Owner

connor4312 commented Apr 1, 2025

This doesn't really work for me, notice L11 is missing a run indicator.

image

I didn't do this initially because I think it's impossible to correctly support, but I would be happy to be wrong.

If we don't support it correctly, then I think a better change would be having a diagnostic warning if duplicate suite names are encountered, e.g. https://github.com/microsoft/vscode-extension-test-runner/blob/90a5dc2008021620c506a4da241cae63afa962ff/src/controller.ts#L457

@ILikeRubberDuckies ILikeRubberDuckies force-pushed the duckies/testsInSameSuitesFix branch from e4c84bc to 5d9004e Compare April 3, 2025 13:12
@ILikeRubberDuckies ILikeRubberDuckies force-pushed the duckies/testsInSameSuitesFix branch from 5d9004e to 8c0c523 Compare April 3, 2025 13:20
@ILikeRubberDuckies
Copy link
Author

ILikeRubberDuckies commented Apr 3, 2025

@connor4312 What do you think of this? Now the run indicators are being displayed correctly.

I find having multiple locations for the same suite to be generally very beneficial, as Node allows hooks to only be applied to specific parts of the suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery of tests in identically-named suites in the same file only works for the last suite
2 participants