Autodetect version tags

Implements #2139

Signed-off-by: Arnout Engelen <[email protected]>

Author: raboof

app/lib/github_basic_detective.rb

@@ -20,6 +20,7 @@ class GithubBasicDetective < Detective
   OUTPUTS = %i[
     name license discussion_status repo_public_status repo_track_status
     repo_distributed_status contribution_status implementation_languages
+    version_tags_status
   ].freeze
 
   # These are the 'correct' display case for SPDX for OSI-approved licenses.
@@ -73,6 +74,10 @@ def language_cleanup(raw_language_data)
     shorter_list.join(', ')
   end
 
+  def version_shaped_tag_in(tag_data)
+    return tag_data.pluck(:name).any? { |tag| tag.match?(/^v?\d+\.\d+\.\d+$/) }
+  end
+
   # Individual detectives must implement "analyze"
   # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
   # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
@@ -170,6 +175,15 @@ def analyze(_evidence, current)
         confidence: 3,
         explanation: 'GitHub API implementation language analysis'
       }
+
+      # Check for version tags
+      if version_shaped_tag_in(client.tags(fullname))
+        results[:version_tags_status] = {
+          value: 'Met',
+          confidence: 2,
+          explanation: 'Version tags are present in the code repository'
+        }
+      end
     end
 
     results

test/unit/lib/github_basic_detective_test.rb

@@ -37,6 +37,14 @@ class GithubBasicDetectiveTest < ActiveSupport::TestCase
       # stub test project by ciitest?
       assert_equal 'Python', results[:implementation_languages][:value]
 
+      # Can we correctly detect version-shaped tags?
+      assert_equal 'Met', results[:version_tags_status][:value]
+
+      assert_not detective.version_shaped_tag_in([])
+      assert_not detective.version_shaped_tag_in([{ name: 'foobar' }])
+      assert detective.version_shaped_tag_in([{ name: '1.2.3' }])
+      assert detective.version_shaped_tag_in([{ name: '1.2.3' }, { name: 'foobar' }])
+
       # Do several unit tests of language_cleanup, it's more complex.
       # This does not invoke network calls, we are directly providing
       # test values to more thoroughly test the method language_cleanup.