Skip to content

Syntax Highlighting: Javascript One-line-Comments #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisgrieser opened this issue Jun 12, 2021 · 1 comment
Closed

Syntax Highlighting: Javascript One-line-Comments #1187

chrisgrieser opened this issue Jun 12, 2021 · 1 comment
Assignees
@1024jp
Labels
bug somethings work not correctly
Milestone
4.0.6

Comments

@chrisgrieser
Copy link

While highlighting for multiline comments /* comment */ works fine, one-line comments // comment do not work properly. See here:
Screen Shot 2021-06-12 at 22 20 36
@1024jp 1024jp added the bug somethings work not correctly label Jun 15, 2021
@1024jp 1024jp added this to the 4.0.6 milestone Jun 15, 2021
@1024jp 1024jp self-assigned this Jun 15, 2021
@1024jp 1024jp mentioned this issue Jun 16, 2021
Open
1024jp added a commit that referenced this issue Jun 20, 2021
@1024jp
Priotarize longer delimiters on comment & quotes highlight (#1187)
7238ae7
1024jp added a commit that referenced this issue Jun 20, 2021
@1024jp
Revert "Update JavaScript style (#1185, #1187)"
8f674ca 
This reverts commit 7b1bbfa.
@1024jp
Copy link
Member

1024jp commented Jun 20, 2021

Thank you for the report.

For the present, I've simply reverted the syntax highlight definition for JavaScript to resolve this issue. That is, the highlight issue on regex comes back instead of fixing this inline comment highlight issue.
I just close this issue and will discuss the further points about JavaScript highlight problems in the original #1185.

@1024jp 1024jp closed this as completed Jun 20, 2021
@chrisgrieser chrisgrieser mentioned this issue Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1024jp 1024jp

Labels
bug somethings work not correctly
Milestone
4.0.6
Development

No branches or pull requests
2 participants
@1024jp @chrisgrieser