lint

Author: JayT106

app/app.go

@@ -715,8 +715,7 @@ func New(
 	// Since the callbacks middleware itself is an ics4wrapper, it needs to be passed to the ica controller keeper
 	app.ICAControllerKeeper.WithICS4Wrapper(icaICS4Wrapper)
 
-	var icaHostStack porttypes.IBCModule
-	icaHostStack = icahost.NewIBCModule(app.ICAHostKeeper)
+	icaHostStack := icahost.NewIBCModule(app.ICAHostKeeper)
 
 	// Create static IBC router, add transfer route, then set and seal it
 	ibcRouter := porttypes.NewRouter()

integration_tests/test_ibc.py

@@ -32,7 +32,12 @@ def ibc(request, tmp_path_factory):
     incentivized = request.param
     name = "ibc"
     path = tmp_path_factory.mktemp(name)
-    yield from prepare_network(path, name, incentivized=incentivized, is_ibc_transfer=True)
+    yield from prepare_network(
+        path,
+        name,
+        incentivized=incentivized,
+        is_ibc_transfer=True,
+    )
 
 
 def test_ibc_transfer(ibc):

integration_tests/test_ibc_rly.py

@@ -247,11 +247,12 @@ def test_ibc(ibc):
     w3 = ibc.cronos.w3
     wait_for_new_blocks(ibc.cronos.cosmos_cli(), 1)
     start = w3.eth.get_block_number()
-    is_hermes = ibc.hermes != None
+    is_hermes = ibc.hermes is not None
 
     if is_hermes:
         ibc_transfer(ibc, hermes_transfer)
-        # we don't check the logs for Hermes due to it doesn't sent evm messages to call the cronos precompiled contract.
+        # we don't check the logs for Hermes due to it doesn't sent evm messages
+        # to call the cronos precompiled contract.
     else:
         ibc_transfer(ibc, rly_transfer)
         denom = ibc_denom(channel, src_denom)
@@ -263,12 +264,41 @@ def test_ibc(ibc):
         transfer_addr = module_address("transfer")
         seq = get_send_packet_seq(chainmain_cli)
         expected = [
-            recv_packet(seq, relayer0, cronos_signer2, src_amount, src_denom),
-            *send_from_module_to_acc(transfer_addr, cronos_signer2, src_amount, denom),
-            fungible(cronos_signer2, relayer, src_amount, src_denom),
-            *send_from_acc_to_module(cronos_signer2, cronos_addr, src_amount, denom),
-            *send_from_module_to_acc(cronos_addr, cronos_signer2, dst_amount, dst_denom),
-            write_ack(seq, relayer0, cronos_signer2, src_amount, src_denom),
+            recv_packet(
+                seq,
+                relayer0,
+                cronos_signer2,
+                src_amount,
+                src_denom),
+            *
+            send_from_module_to_acc(
+                transfer_addr,
+                cronos_signer2,
+                src_amount,
+                denom),
+            fungible(
+                cronos_signer2,
+                relayer,
+                src_amount,
+                src_denom),
+            *
+            send_from_acc_to_module(
+                cronos_signer2,
+                cronos_addr,
+                src_amount,
+                denom),
+            *
+            send_from_module_to_acc(
+                cronos_addr,
+                cronos_signer2,
+                dst_amount,
+                dst_denom),
+            write_ack(
+                seq,
+                relayer0,
+                cronos_signer2,
+                src_amount,
+                src_denom),
         ]
         assert len(logs) == len(expected)
         height = logs[0]["blockNumber"]
@@ -289,7 +319,7 @@ def get_escrow_address(cli, channel):
     )
 
 
-@pytest.mark.skip("skipping test_ibc_incentivized_transfer due to unsupported precompiled contract in hermes relayer")
+@pytest.mark.skip("skipping due to unsupported precompiled contract in hermes")
 def test_ibc_incentivized_transfer(ibc):
     w3 = ibc.cronos.w3
     cli = ibc.cronos.cosmos_cli()
@@ -386,12 +416,12 @@ def assert_transfer_source_tokens_topics(ibc, fn):
             assert ftopic == topic, method_name
 
 
-@pytest.mark.skip("skipping test_cronos_transfer_source_tokens due to unsupported precompiled contract in hermes relayer")
+@pytest.mark.skip("skipping due to unsupported precompiled contract in hermes")
 def test_cronos_transfer_source_tokens(ibc):
     assert_transfer_source_tokens_topics(ibc, cronos_transfer_source_tokens)
 
 
-@pytest.mark.skip("skipping test_cronos_transfer_source_tokens_with_proxy due to unsupported precompiled contract in hermes relayer")
+@pytest.mark.skip("skipping due to unsupported precompiled contract in hermes")
 def test_cronos_transfer_source_tokens_with_proxy(ibc):
     assert_transfer_source_tokens_topics(ibc, cronos_transfer_source_tokens_with_proxy)
 

integration_tests/test_ibc_rly_gas.py

@@ -33,10 +33,10 @@ def test_ibc(ibc):
     cli = ibc.cronos.cosmos_cli()
     wait_for_new_blocks(cli, 1)
     ibc_transfer(ibc)
-    
+
     if ibc.hermes is None:
         ibc_incentivized_transfer(ibc)
-    
+
     ibc_multi_transfer(ibc)
     diff = 0.15
     record = log_gas_records(cli)

integration_tests/test_ibc_update_client.py

@@ -14,7 +14,13 @@ def ibc(request, tmp_path_factory):
     "prepare-network"
     name = "ibc"
     path = tmp_path_factory.mktemp(name)
-    yield from prepare_network(path, name, is_relay=False, is_ibc_transfer=True, incentivized=False)
+    yield from prepare_network(
+        path,
+        name,
+        is_relay=False,
+        is_ibc_transfer=True,
+        incentivized=False,
+    )
 
 
 def test_ibc_update_client(ibc, tmp_path):

integration_tests/test_ica.py

@@ -112,7 +112,8 @@ def submit_msgs(msg_num, timeout_in_s=no_timeout, gas="200000"):
     submit_msgs(msg_num, 0.005, "600000")
     assert cli_host.balance(ica_address, denom=denom) == balance
     if order == ChannelOrder.UNORDERED.value:
-        # regiser new account for unordered channel, will not update the original channel.
+        # regiser new account for unordered channel, will not update the original
+        # channel.
         register_acc(cli_controller, connid)
     else:
         # rly: ibc_upgrade_channels not work

integration_tests/test_ica_incentivized.py

@@ -22,7 +22,7 @@ def ibc(request, tmp_path_factory):
     yield from prepare_network(path, name)
 
 
-@pytest.mark.skip(reason="skip for now, the ibc-fee module has been removed in the ibc-go v10")
+@pytest.mark.skip("The ibc-fee module has been removed in the ibc-go v10")
 def test_incentivized(ibc):
     connid = "connection-0"
     cli_host = ibc.chainmain.cosmos_cli()

integration_tests/test_ica_precompile.py

@@ -227,7 +227,7 @@ def check_log():
     wait_for_fn("packet log", check_log)
 
 
-@pytest.mark.skip("skipping test_sc_call due to unsupported precompiled contract in hermes relayer")
+@pytest.mark.skip("skipping due to unsupported precompiled contract in hermes")
 @pytest.mark.parametrize("order", [Ordering.ORDERED.value, Ordering.UNORDERED.value])
 def test_sc_call(ibc, order):
     cli_host = ibc.chainmain.cosmos_cli()

nix/default.nix

@@ -60,23 +60,27 @@ import sources.nixpkgs {
           ];
         };
       };
-     })
+    })
     (_: pkgs: {
-        hermes = let
+      hermes =
+        let
           # The informalsystems/hermes v1.13.1 requires rust version >= v1.83
           # The nixpkgs 24.11 is using rust version v1.82
           # Use fenix to select different rust toolchain version
-          rustToolchain = (import sources.fenix {
-            inherit system;
-          }).fromToolchainFile {
-            file = ./rust-toolchain.toml;
-            sha256 = "sha256-s1RPtyvDGJaX/BisLT+ifVfuhDT1nZkZ1NcK8sbwELM=";
-          };
+          rustToolchain =
+            (import sources.fenix {
+              inherit system;
+            }).fromToolchainFile
+              {
+                file = ./rust-toolchain.toml;
+                sha256 = "sha256-s1RPtyvDGJaX/BisLT+ifVfuhDT1nZkZ1NcK8sbwELM=";
+              };
           fenixRustPlatform = pkgs.makeRustPlatform {
             cargo = rustToolchain;
             rustc = rustToolchain;
           };
-          in pkgs.callPackage ./hermes.nix {
+        in
+        pkgs.callPackage ./hermes.nix {
           src = sources.hermes;
           rustPlatform = fenixRustPlatform;
         };

nix/hermes.nix

@@ -22,7 +22,7 @@ rustPlatform.buildRustPackage rec {
     protobuf
   ];
   cargoLock = {
-    lockFile = "${src}/Cargo.lock"; 
+    lockFile = "${src}/Cargo.lock";
   };
   doCheck = false;
   RUSTFLAGS = "--cfg ossl111 --cfg ossl110 --cfg ossl101";
@@ -36,4 +36,4 @@ rustPlatform.buildRustPackage rec {
   };
   PROTOC = "${protobuf}/bin/protoc";
   PROTOC_INCLUDE = "${protobuf}/include";
-}
+}