Skip to content

Commit 08316c3

Browse files
authored
Merge of #566
2 parents a51e83d + 9e60d6e commit 08316c3

File tree

7 files changed

+67
-45
lines changed

7 files changed

+67
-45
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/container-storage-interface/spec v1.9.0
77
github.com/csi-addons/spec v0.2.1-0.20230606140122-d20966d2e444
88
github.com/go-logr/logr v1.4.1
9-
github.com/kubernetes-csi/csi-lib-utils v0.17.0
9+
github.com/kubernetes-csi/csi-lib-utils v0.18.0
1010
github.com/onsi/ginkgo v1.16.5
1111
github.com/onsi/gomega v1.33.1
1212
github.com/robfig/cron/v3 v3.0.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
9494
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
9595
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
9696
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
97-
github.com/kubernetes-csi/csi-lib-utils v0.17.0 h1:xEpJ3WYgMyyYF6fvcKHh4cDRtknuTkBS9rG8bYoLTCU=
98-
github.com/kubernetes-csi/csi-lib-utils v0.17.0/go.mod h1:2Ba5/aQgUjbpqyC2uCcFwMF3rnPVs5jhZXm8jAzcT9Q=
97+
github.com/kubernetes-csi/csi-lib-utils v0.18.0 h1:Tpt1qLIbmpz5ux1hllut/dEWww2VRxdvSSOF4gGwhnA=
98+
github.com/kubernetes-csi/csi-lib-utils v0.18.0/go.mod h1:FEQIcHcZmXZKWKTg18dJbXCHvgtCjnH7/uM0trmZyhU=
9999
github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
100100
github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
101101
github.com/matttproud/golang_protobuf_extensions/v2 v2.0.0 h1:jWpvCLoY8Z/e3VKvlsiIGKtc+UG6U5vzxaoagmhXfyg=

sidecar/internal/client/client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ type clientImpl struct {
5151
}
5252

5353
// Connect to the GRPC client
54-
func (c *clientImpl) connect(address string) (*grpc.ClientConn, error) {
55-
return connection.Connect(address, metrics.NewCSIMetricsManager(""), connection.OnConnectionLoss(connection.ExitOnConnectionLoss()))
54+
func (c *clientImpl) connect(ctx context.Context, address string) (*grpc.ClientConn, error) {
55+
return connection.Connect(ctx, address, metrics.NewCSIMetricsManager(""), connection.OnConnectionLoss(connection.ExitOnConnectionLoss()))
5656
}
5757

5858
// New creates and returns the GRPC client
59-
func New(address string, timeout time.Duration) (Client, error) {
59+
func New(ctx context.Context, address string, timeout time.Duration) (Client, error) {
6060
c := &clientImpl{}
61-
cc, err := c.connect(address)
61+
cc, err := c.connect(ctx, address)
6262
if err != nil {
6363
return nil, err
6464
}

sidecar/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func main() {
7575
klog.Fatalf("Failed to validate controller endpoint: %v", err)
7676
}
7777

78-
csiClient, err := client.New(*csiAddonsAddress, *timeout)
78+
csiClient, err := client.New(context.Background(), *csiAddonsAddress, *timeout)
7979
if err != nil {
8080
klog.Fatalf("Failed to connect to %q : %v", *csiAddonsAddress, err)
8181
}

vendor/github.com/kubernetes-csi/csi-lib-utils/connection/connection.go

Lines changed: 43 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/kubernetes-csi/csi-lib-utils/leaderelection/leader_election.go

Lines changed: 14 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ github.com/josharian/intern
102102
# github.com/json-iterator/go v1.1.12
103103
## explicit; go 1.12
104104
github.com/json-iterator/go
105-
# github.com/kubernetes-csi/csi-lib-utils v0.17.0
106-
## explicit; go 1.21
105+
# github.com/kubernetes-csi/csi-lib-utils v0.18.0
106+
## explicit; go 1.22.0
107107
github.com/kubernetes-csi/csi-lib-utils/accessmodes
108108
github.com/kubernetes-csi/csi-lib-utils/connection
109109
github.com/kubernetes-csi/csi-lib-utils/leaderelection

0 commit comments

Comments
 (0)