sidecar: Handle error correctly inside DispatchWatcher

black-dragon74 · mergify[bot] · commit 486cd479ffce · 2025-03-07T12:17:22.000Z
This patch propagates the error returned from getCSIAddonsNode

Signed-off-by: Niraj Yadav &lt;niryadav@redhat.com&gt;
diff --git a/sidecar/internal/csiaddonsnode/csiaddonsnode.go b/sidecar/internal/csiaddonsnode/csiaddonsnode.go
@@ -342,7 +342,7 @@ func (mgr *Manager) DispatchWatcher() error {
 	retryCount := 0
 	node, err := mgr.getCSIAddonsNode()
 	if err != nil {
-		return errors.New("failed to get CSIAddonsNode object")
+		return fmt.Errorf("failed to get CSIAddonsNode object due to error: %w", err)
 	}
 
 	for retryCount < int(watcherRetryCount) {

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ func (mgr *Manager) DispatchWatcher() error {`
`342`	`342`	`retryCount := 0`
`343`	`343`	`node, err := mgr.getCSIAddonsNode()`
`344`	`344`	`if err != nil {`
`345`		`- return errors.New("failed to get CSIAddonsNode object")`
	`345`	`+ return fmt.Errorf("failed to get CSIAddonsNode object due to error: %w", err)`
`346`	`346`	`}`
`347`	`347`
`348`	`348`	`for retryCount < int(watcherRetryCount) {`