Skip to content

Make defaultIdleTimeout configurable via configmap #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
black-dragon74 opened this issue Apr 18, 2025 · 0 comments
Open

Make defaultIdleTimeout configurable via configmap #796

black-dragon74 opened this issue Apr 18, 2025 · 0 comments
Assignees
@black-dragon74

Comments

@black-dragon74
Copy link
Member 

          `defaultIdleTimeout` was just a suggested name, I didn't see it was used elsewhere already. It was mostly about the capitalization of the name.

Whatever calls NewConnection() might be able to pass an alternative timeout. There should definitely be no configmap usage within these structs or package. It could be an improvement for a followup PR.

Originally posted by @nixpanic in #794 (comment)
@black-dragon74 black-dragon74 self-assigned this Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@black-dragon74 black-dragon74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@black-dragon74