Skip to content

Commit 55617ee

Browse files
committed
GUI: do not ignore enter in terminal input
1 parent 8bd7d92 commit 55617ee

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/gui/windows/terminal/terminaldock.cpp

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
#include <QTextBlock>
77
#include <QTextCursor>
88

9-
TerminalDock::TerminalDock(QWidget *parent, QSettings *settings)
10-
: QDockWidget(parent) {
9+
TerminalDock::TerminalDock(QWidget *parent, QSettings *settings) : QDockWidget(parent) {
1110
(void)settings;
1211
top_widget = new QWidget(this);
1312
setWidget(top_widget);
@@ -22,24 +21,22 @@ TerminalDock::TerminalDock(QWidget *parent, QSettings *settings)
2221
input_edit = new QLineEdit();
2322
layout_bottom_box->addWidget(input_edit);
2423
layout_box->addLayout(layout_bottom_box);
24+
// insert newline on enter (it will be displayed as space)
25+
connect(input_edit, &QLineEdit::returnPressed, [this]() {
26+
input_edit->setText(input_edit->text() + '\n');
27+
});
2528

2629
setObjectName("Terminal");
2730
setWindowTitle("Terminal");
2831
}
2932

3033
void TerminalDock::setup(machine::SerialPort *ser_port) {
31-
if (ser_port == nullptr) {
32-
return;
33-
}
34+
if (ser_port == nullptr) { return; }
3435
connect(
3536
ser_port, &machine::SerialPort::tx_byte, this,
3637
QOverload<unsigned int>::of(&TerminalDock::tx_byte));
37-
connect(
38-
ser_port, &machine::SerialPort::rx_byte_pool, this,
39-
&TerminalDock::rx_byte_pool);
40-
connect(
41-
input_edit, &QLineEdit::textChanged, ser_port,
42-
&machine::SerialPort::rx_queue_check);
38+
connect(ser_port, &machine::SerialPort::rx_byte_pool, this, &TerminalDock::rx_byte_pool);
39+
connect(input_edit, &QLineEdit::textChanged, ser_port, &machine::SerialPort::rx_queue_check);
4340
}
4441

4542
void TerminalDock::tx_byte(unsigned int data) {

0 commit comments

Comments
 (0)