Skip to content

ci: update to ubuntu 24.04 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

MikeMcC399
Copy link
Contributor

Situation

The workflow .github/workflows/main.yml uses the GitHub Actions runner image ubuntu-22.04.

This is not the latest Ubuntu version. See ubuntu-24.04 which is labeled ubuntu-latest.

Other active repos, including the equivalent workflow in cypress-io/component-testing-quickstart-apps repo, have already been migrated to use ubuntu-24.04.

Change

Update the workflow .github/workflows/main.yml to use the GitHub Actions runner image ubuntu-24.04 - corresponding to ubuntu-latest.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane / @AtofStryker

Would you approve the workflow here? It seems I haven't contributed to this repo previously.

The repo may be a good candidate to provide an updated Angular example to the CircleCI-Orb repo https://github.com/cypress-io/circleci-orb/tree/master/examples/angular-app which would save "re-inventing the wheel".

There are a few tweaks that could be done in these examples to remove warnings, etc. and I would take these on if you can handle reviewing and merging some follow-on PRs.

@AtofStryker
Copy link
Contributor

Would you approve the workflow here? It seems I haven't contributed to this repo previously.

@MikeMcC399 Approved. It should now be running!

@MikeMcC399
Copy link
Contributor Author

@AtofStryker

@MikeMcC399 Approved. It should now be running!

Thank you! As expected, it ran successfully, so now I just need a PR approval and merge when time permits.

@AtofStryker AtofStryker merged commit b7447ff into cypress-io:main Apr 17, 2025
10 checks passed
@MikeMcC399 MikeMcC399 deleted the ci/ubuntu-24.04 branch April 18, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants