fix

Author: forsaken628

src/query/functions/src/aggregates/adaptors/aggregate_null_adaptor.rs

@@ -15,6 +15,7 @@
 use std::fmt;
 use std::sync::Arc;
 
+use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 use databend_common_expression::types::Bitmap;
 use databend_common_expression::types::DataType;
@@ -189,15 +190,19 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction for AggregateNullUnaryAdapto
     }
 
     fn serialize_binary(&self, _: AggrState, _: &mut Vec<u8>) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to serialize_binary should be refactored to calls to serialize",
+        ))
     }
 
     fn merge(&self, place: AggrState, data: &[ScalarRef]) -> Result<()> {
         self.0.merge(place, data)
     }
 
     fn merge_binary(&self, _: AggrState, _: &mut &[u8]) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to merge_binary should be refactored to calls to merge",
+        ))
     }
 
     fn merge_states(&self, place: AggrState, rhs: AggrState) -> Result<()> {
@@ -318,15 +323,19 @@ impl<const NULLABLE_RESULT: bool> AggregateFunction
     }
 
     fn serialize_binary(&self, _: AggrState, _: &mut Vec<u8>) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to serialize_binary should be refactored to calls to serialize",
+        ))
     }
 
     fn merge(&self, place: AggrState, data: &[ScalarRef]) -> Result<()> {
         self.0.merge(place, data)
     }
 
     fn merge_binary(&self, _: AggrState, _: &mut &[u8]) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to merge_binary should be refactored to calls to merge",
+        ))
     }
 
     fn merge_states(&self, place: AggrState, rhs: AggrState) -> Result<()> {

src/query/functions/src/aggregates/adaptors/aggregate_ornull_adaptor.rs

@@ -15,6 +15,7 @@
 use std::fmt;
 use std::sync::Arc;
 
+use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 use databend_common_expression::types::Bitmap;
 use databend_common_expression::types::DataType;
@@ -198,7 +199,9 @@ impl AggregateFunction for AggregateFunctionOrNullAdaptor {
     }
 
     fn serialize_binary(&self, _: AggrState, _: &mut Vec<u8>) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to serialize_binary should be refactored to calls to serialize",
+        ))
     }
 
     fn merge(&self, place: AggrState, data: &[ScalarRef]) -> Result<()> {
@@ -210,7 +213,9 @@ impl AggregateFunction for AggregateFunctionOrNullAdaptor {
     }
 
     fn merge_binary(&self, _: AggrState, _: &mut &[u8]) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to merge_binary should be refactored to calls to merge",
+        ))
     }
 
     fn merge_states(&self, place: AggrState, rhs: AggrState) -> Result<()> {

src/query/functions/src/aggregates/aggregate_combinator_if.rs

@@ -164,15 +164,19 @@ impl AggregateFunction for AggregateIfCombinator {
     }
 
     fn serialize_binary(&self, _: AggrState, _: &mut Vec<u8>) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to serialize_binary should be refactored to calls to serialize",
+        ))
     }
 
     fn merge(&self, place: AggrState, data: &[ScalarRef]) -> Result<()> {
         self.nested.merge(place, data)
     }
 
     fn merge_binary(&self, _: AggrState, _: &mut &[u8]) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to merge_binary should be refactored to calls to merge",
+        ))
     }
 
     fn merge_states(&self, place: AggrState, rhs: AggrState) -> Result<()> {

src/query/functions/src/aggregates/aggregate_combinator_state.rs

@@ -15,6 +15,7 @@
 use std::fmt;
 use std::sync::Arc;
 
+use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 use databend_common_expression::types::Bitmap;
 use databend_common_expression::types::DataType;
@@ -117,15 +118,19 @@ impl AggregateFunction for AggregateStateCombinator {
     }
 
     fn serialize_binary(&self, _: AggrState, _: &mut Vec<u8>) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to serialize_binary should be refactored to calls to serialize",
+        ))
     }
 
     fn merge(&self, place: AggrState, data: &[ScalarRef]) -> Result<()> {
         self.nested.merge(place, data)
     }
 
     fn merge_binary(&self, _: AggrState, _: &mut &[u8]) -> Result<()> {
-        unreachable!()
+        Err(ErrorCode::Internal(
+            "Calls to merge_binary should be refactored to calls to merge",
+        ))
     }
 
     fn merge_states(&self, place: AggrState, rhs: AggrState) -> Result<()> {