Skip to content

[BUZZOK-26844] Remove drum server from everywhere in genai_agents image, replace with drum inline predictor #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025

Conversation

mjnitz02
Copy link
Contributor

@mjnitz02 mjnitz02 commented Jul 17, 2025

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

This removes the use of the DRUM Server from everywhere in run_agent. Instead we are now using the drum_inline_predictor which is a python process that runs in memory without requiring any extra services or threads to be spun up.

This is:

  • Faster to start
  • More efficient and uses no extra ports
  • Shows the errors properly in all failure conditions
  • Easier to debug and maintain

@engprod-2
Copy link

engprod-2 bot commented Jul 17, 2025

The Needs Review labels were added based on the following file changes.

Team @datarobot/buzok (#buzok) was assigned because of changes in files:

public_dropin_environments/python311_genai_agents/env_info.json
public_dropin_environments/python311_genai_agents/requirements.in
public_dropin_environments/python311_genai_agents/requirements.txt
public_dropin_environments/python311_genai_agents/run_agent.py

If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file.

@mjnitz02 mjnitz02 changed the title [BUZZOK-26844] Remove drum server from everywhere [BUZZOK-26844] Remove drum server from everywhere in genai_agents image Jul 17, 2025
@mjnitz02 mjnitz02 changed the title [BUZZOK-26844] Remove drum server from everywhere in genai_agents image [BUZZOK-26844] Remove drum server from everywhere in genai_agents image, replace with drum inline predictor Jul 17, 2025
@svc-engprod-git1 svc-engprod-git1 requested a review from akshoop July 18, 2025 13:54
Copy link
Contributor

@akshoop akshoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjnitz02 mjnitz02 merged commit c68cb7b into master Jul 18, 2025
32 checks passed
@svc-engprod-git1 svc-engprod-git1 deleted the mattn/BUZZOK-26844-remove-drum-server branch July 18, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants