ci: replace always() condition with recommended !cancelled()

amezin · amezin · commit 75ecebd0395b · 2025-06-17T01:56:45.000+03:00
diff --git a/.github/actions/container-test/action.yml b/.github/actions/container-test/action.yml
@@ -65,7 +65,7 @@ runs:
       env:
         CONTAINER: ${{ inputs.container }}
 
-    - if: always() && steps.setup-testspace.outcome == 'success'
+    - if: ${{ !cancelled() && steps.setup-testspace.outcome == 'success' }}
       shell: bash
       run: >-
         testspace --verbose
@@ -74,7 +74,7 @@ runs:
       env:
         CONTAINER: ${{ inputs.container }}
 
-    - if: always() && steps.test.outcome != 'skipped' && steps.test.outcome != 'cancelled'
+    - if: ${{ !cancelled() }}
       uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
       with:
         name: ${{ inputs.container }}-reports
diff --git a/.github/actions/eslint/action.yml b/.github/actions/eslint/action.yml
@@ -19,4 +19,4 @@ runs:
     - uses: ./.github/actions/eslint-stylish-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.eslint-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.eslint-problem-matcher.outcome == 'success' }}
diff --git a/.github/actions/flake8/action.yml b/.github/actions/flake8/action.yml
@@ -17,4 +17,4 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.flake8-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.flake8-problem-matcher.outcome == 'success' }}
diff --git a/.github/actions/markdownlint/action.yml b/.github/actions/markdownlint/action.yml
@@ -17,4 +17,4 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.markdownlint-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.markdownlint-problem-matcher.outcome == 'success' }}
diff --git a/.github/actions/meson-format/action.yml b/.github/actions/meson-format/action.yml
@@ -20,7 +20,7 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.generic-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.generic-problem-matcher.outcome == 'success' }}
 
     - shell: bash
       run: |
@@ -32,4 +32,4 @@ runs:
 
     - run: git reset --hard
       shell: bash
-      if: always()
+      if: ${{ !cancelled() }}
diff --git a/.github/actions/npm-install/action.yml b/.github/actions/npm-install/action.yml
@@ -17,4 +17,4 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.npm-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.npm-problem-matcher.outcome == 'success' }}
diff --git a/.github/actions/pict/action.yml b/.github/actions/pict/action.yml
@@ -20,7 +20,7 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.generic-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.generic-problem-matcher.outcome == 'success' }}
 
     - shell: bash
       run: |
@@ -32,4 +32,4 @@ runs:
 
     - run: git reset --hard
       shell: bash
-      if: always()
+      if: ${{ !cancelled() }}
diff --git a/.github/actions/pip-compile/action.yml b/.github/actions/pip-compile/action.yml
@@ -20,7 +20,7 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.generic-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.generic-problem-matcher.outcome == 'success' }}
 
     - shell: bash
       run: |
@@ -32,4 +32,4 @@ runs:
 
     - run: git reset --hard
       shell: bash
-      if: always()
+      if: ${{ !cancelled() }}
diff --git a/.github/actions/reuse/action.yml b/.github/actions/reuse/action.yml
@@ -17,4 +17,4 @@ runs:
     - uses: ./.github/actions/reuse-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.reuse-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.reuse-problem-matcher.outcome == 'success' }}
diff --git a/.github/actions/tox-preinstall/action.yml b/.github/actions/tox-preinstall/action.yml
@@ -27,4 +27,4 @@ runs:
     - uses: ./.github/actions/generic-problem-matcher
       with:
         enable: false
-      if: ${{ always() && steps.tox-problem-matcher.outcome == 'success' }}
+      if: ${{ !cancelled() && steps.tox-problem-matcher.outcome == 'success' }}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -99,46 +99,46 @@ jobs:
       - name: Install development dependencies from npm
         id: npm
         uses: ./.github/actions/npm-install
-        if: ${{ always() && steps.checkout.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.checkout.outcome == 'success' }}
 
       - name: Install Python dependencies
         id: pip
         uses: ./.github/actions/tox-preinstall
         with:
           environments: reuse,version,flake8,meson-format,pip-compile
-        if: ${{ always() && steps.checkout.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.checkout.outcome == 'success' }}
 
       - name: Lint JS code with ESLint
         uses: ./.github/actions/eslint
-        if: ${{ always() && steps.npm.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.npm.outcome == 'success' }}
 
       - name: Lint Python code with flake8
         uses: ./.github/actions/flake8
-        if: ${{ always() && steps.pip.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pip.outcome == 'success' }}
 
       - name: Lint Markdown files
         uses: ./.github/actions/markdownlint
-        if: ${{ always() && steps.npm.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.npm.outcome == 'success' }}
 
       - name: Check repository REUSE compliance
         uses: ./.github/actions/reuse
-        if: ${{ always() && steps.pip.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pip.outcome == 'success' }}
 
       - name: Check meson.build formatting
         uses: ./.github/actions/meson-format
-        if: ${{ always() && steps.pip.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pip.outcome == 'success' }}
 
       - name: Check Python requirements .txt files
         uses: ./.github/actions/pip-compile
-        if: ${{ always() && steps.pip.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pip.outcome == 'success' }}
 
       - name: Check version number
         run: tox -e version
-        if: ${{ always() && steps.pip.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pip.outcome == 'success' }}
 
       - name: Check PICT test cases
         uses: ./.github/actions/pict
-        if: ${{ always() && steps.checkout.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.checkout.outcome == 'success' }}
 
   extension-package:
     runs-on: ubuntu-24.04
@@ -173,17 +173,17 @@ jobs:
           name: ${{ github.job }}
           path: "build/*.shell-extension.zip"
           if-no-files-found: error
-        if: ${{ always() && steps.pack.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pack.outcome == 'success' }}
 
       - name: Run checks
         run: xvfb-run -d --server-args=-noreset --wait=0 -- meson test -v -j1
         working-directory: build
         shell: pipetty bash -e {0}
-        if: ${{ always() && steps.pack.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pack.outcome == 'success' }}
 
       - name: Check REUSE compliance of generated package
         run: tox -e reuse-pack -- build/*.shell-extension.zip
-        if: ${{ always() && steps.pack.outcome == 'success' }}
+        if: ${{ !cancelled() && steps.pack.outcome == 'success' }}
 
       - name: Generate a list of input files
         id: ninja-inputs
@@ -417,7 +417,7 @@ jobs:
       - archlinux-package-check
       - archlinux-installed-test
 
-    if: always() && needs.extension-package.result == 'success'
+    if: ${{ !cancelled() && needs.extension-package.result == 'success' }}
     runs-on: ubuntu-24.04
     timeout-minutes: 5
 
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -23,7 +23,7 @@ jobs:
 
   publish:
     needs: ci
-    if: always() && needs.ci.outputs.pages != 'false'
+    if: ${{ !cancelled() && needs.ci.outputs.pages != 'false' }}
     runs-on: ubuntu-24.04
     timeout-minutes: 5
 
