Skip to content

All branches of if-then-elseif construction are identical #6030

New issue
New issue
Open
#6670
Open
All branches of if-then-elseif construction are identical#6030
#6670
Labels
good first issueGood for newcomers
@chavacava

Description

@chavacava
chavacava
opened on Oct 25, 2024

Every branch of the following if-then-elseif construction do the same (_, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)

devtron/pkg/appStore/discover/repository/AppStoreApplicationVersionRepository.go

Lines 179 to 187 in fb1cbf5

if len(filter.ChartRepoId) > 0 && len(filter.RegistryId) > 0 {
_, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)
} else if len(filter.RegistryId) > 0 {
_, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)
} else if len(filter.ChartRepoId) > 0 {
_, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)
} else {
_, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)
}

Found with revive

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions