Fix drift check logic for no chnages (#1843)

chiragsoni-employ · web-flow · commit 94a9e00e6ef5 · 2024-11-25T15:02:29.000Z
diff --git a/libs/iac_utils/terraform.go b/libs/iac_utils/terraform.go
@@ -39,8 +39,11 @@ func (tu TerraformUtils) GetSummaryFromPlanJson(planJson string) (bool, *IacSumm
 		}
 	}
 
-	if tfplan.OutputChanges != nil {
-		isPlanEmpty = false
+	for _, change := range tfplan.OutputChanges {
+		if len(change.Actions) != 1 || change.Actions[0] != "no-op" {
+			isPlanEmpty = false
+			break
+		}
 	}
 
 	planSummary := IacSummary{}

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,11 @@ func (tu TerraformUtils) GetSummaryFromPlanJson(planJson string) (bool, *IacSumm`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`
`42`		`- if tfplan.OutputChanges != nil {`
`43`		`- isPlanEmpty = false`
	`42`	`+ for _, change := range tfplan.OutputChanges {`
	`43`	`+ if len(change.Actions) != 1 \|\| change.Actions[0] != "no-op" {`
	`44`	`+ isPlanEmpty = false`
	`45`	`+ break`
	`46`	`+ }`
`44`	`47`	`}`
`45`	`48`
`46`	`49`	`planSummary := IacSummary{}`