Skip to content

Commit 4266df2

Browse files
Correct unit test merge issue (Fact/WinFormsFact).
1 parent 155fa75 commit 4266df2

File tree

1 file changed

+13
-17
lines changed

1 file changed

+13
-17
lines changed

src/test/unit/System.Windows.Forms/System/Windows/Forms/ControlTests_InvokeAsync.cs

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ private sealed class TestControl : Control
1414
public void DestroyTestHandle() => DestroyHandle();
1515
}
1616

17-
[Fact]
17+
[WinFormsFact]
1818
public async Task InvokeAsync_Action_ExecutesOnUIThread()
1919
{
2020
using var control = new TestControl();
@@ -55,7 +55,7 @@ void UiAccessAction()
5555
}
5656
}
5757

58-
[Fact]
58+
[WinFormsFact]
5959
public async Task InvokeAsync_FuncT_ExecutesOnUIThread_AndReturnsValue()
6060
{
6161
using var control = new TestControl();
@@ -92,7 +92,7 @@ int UiAccessFunc()
9292
}
9393
}
9494

95-
[Fact]
95+
[WinFormsFact]
9696
public async Task InvokeAsync_AsyncCallback_ExecutesOnUIThread()
9797
{
9898
using var control = new TestControl();
@@ -178,7 +178,7 @@ async ValueTask UiAccessAsyncCallback(CancellationToken ct)
178178
}
179179
}
180180

181-
[Fact]
181+
[WinFormsFact]
182182
public async Task InvokeAsync_AsyncCallbackT_ExecutesOnUIThread_AndReturnsValue()
183183
{
184184
using var control = new TestControl();
@@ -226,7 +226,7 @@ async ValueTask<int> UiAccessAsyncCallback(CancellationToken ct)
226226
}
227227
}
228228

229-
[Fact]
229+
[WinFormsFact]
230230
public async Task InvokeAsync_Action_Cancellation_PreCancelledToken_ReturnsEarly()
231231
{
232232
using var control = new TestControl();
@@ -240,7 +240,7 @@ await control.InvokeAsync(
240240
.ConfigureAwait(false);
241241
}
242242

243-
[Fact]
243+
[WinFormsFact]
244244
public async Task InvokeAsync_FuncT_Cancellation_PreCancelledToken_ReturnsDefault()
245245
{
246246
using var control = new TestControl();
@@ -262,7 +262,7 @@ static ValueTask<int> CallBack(CancellationToken ct)
262262
}
263263
}
264264

265-
[Fact]
265+
[WinFormsFact]
266266
public async Task InvokeAsync_AsyncCallback_Cancellation_PreCancelledToken_ReturnsEarly()
267267
{
268268
using var control = new TestControl();
@@ -276,7 +276,7 @@ await control.InvokeAsync(
276276
cts.Token).ConfigureAwait(true);
277277
}
278278

279-
[Fact]
279+
[WinFormsFact]
280280
public async Task InvokeAsync_AsyncCallbackT_Cancellation_PreCancelledToken_ReturnsDefault()
281281
{
282282
using var control = new TestControl();
@@ -293,10 +293,6 @@ public async Task InvokeAsync_AsyncCallbackT_Cancellation_PreCancelledToken_Retu
293293
}
294294

295295
[WinFormsFact]
296-
[Diagnostics.CodeAnalysis.SuppressMessage(
297-
"Performance",
298-
"CA1849:Call async methods when in an async method",
299-
Justification = "We're blocking for the test on purpose.")]
300296
public async Task InvokeAsync_Action_Cancellation_BeforeExecution()
301297
{
302298
using var control = new TestControl();
@@ -354,7 +350,7 @@ await Assert.ThrowsAnyAsync<OperationCanceledException>(
354350
.ConfigureAwait(false);
355351
}
356352

357-
[Fact]
353+
[WinFormsFact]
358354
public async Task InvokeAsync_AsyncCallback_Cancellation_WhileRunning()
359355
{
360356
using var control = new TestControl();
@@ -374,7 +370,7 @@ await Assert.ThrowsAnyAsync<OperationCanceledException>(
374370
async () => await task.ConfigureAwait(false)).ConfigureAwait(false);
375371
}
376372

377-
[Fact]
373+
[WinFormsFact]
378374
public async Task InvokeAsync_Throws_InvalidOperationException_IfHandleNotCreated()
379375
{
380376
using var control = new TestControl();
@@ -395,7 +391,7 @@ await Assert.ThrowsAsync<InvalidOperationException>(() =>
395391
control.InvokeAsync(() => { })).ConfigureAwait(false);
396392
}
397393

398-
[Fact]
394+
[WinFormsFact]
399395
public async Task InvokeAsync_Propagates_Exception_FromCallback()
400396
{
401397
using var control = new TestControl();
@@ -418,7 +414,7 @@ await Assert.ThrowsAsync<InvalidOperationException>(() =>
418414
.ConfigureAwait(false);
419415
}
420416

421-
[Fact]
417+
[WinFormsFact]
422418
public async Task InvokeAsync_Reentry_Supported()
423419
{
424420
using var control = new TestControl();
@@ -435,7 +431,7 @@ await control.InvokeAsync(() => innerCalled = true, ct)
435431
Assert.True(innerCalled);
436432
}
437433

438-
[Fact]
434+
[WinFormsFact]
439435
public async Task InvokeAsync_MultipleConcurrentCalls_AreThreadSafe()
440436
{
441437
using var control = new TestControl();

0 commit comments

Comments
 (0)