Skip to content

core/config/spam_reporting: Update path #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mariuszkrzaczkowski
Copy link
Contributor

No description provided.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

antispam

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:mariuszkrzaczkowski/documentation-1.git repository
on the patch-2 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.23/apply.pl' |
perl - 'https://github.com/dovecot/documentation/actions/runs/14704204995/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@slusarz
Copy link
Contributor

slusarz commented Apr 28, 2025

"/etc/dovecot/conf.d/99-antispam.conf" isn't something that is supported by Dovecot out-of-the-box. It requires additional base configuration to work.

Regardless, it is the goal of the documentation that all configuration lives in a single configuration file for simplicity. Abstracting out components into sub-configs is beyond the scope.

@mariuszkrzaczkowski
Copy link
Contributor Author

"/etc/dovecot/conf.d/99-antispam.conf" isn't something that is supported by Dovecot out-of-the-box. It requires additional base configuration to work.

It worked for me immediately after creating the file

Regardless, it is the goal of the documentation that all configuration lives in a single configuration file for simplicity. Abstracting out components into sub-configs is beyond the scope.

Consider splitting into smaller files for better organization, it is easier to identify which code is responsible for what and one file is difficult to read

@sirainen
Copy link
Contributor

sirainen commented May 6, 2025

We used to split default configuration into small pieces, but it caused confusion, especially in documentation. Now documentation everywhere says settings are in dovecot.conf, regardless of where admins may eventually prefer to put them.

@sirainen sirainen closed this May 6, 2025
@mariuszkrzaczkowski mariuszkrzaczkowski deleted the patch-2 branch May 7, 2025 06:46
@mariuszkrzaczkowski
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants