Skip to content

dracut does not add all required libraries if /etc/ld.so.preload contains a missing library #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aafeijoo-suse opened this issue Feb 27, 2023 · 4 comments · Fixed by dracut-ng/dracut-ng#127 · May be fixed by #2243
Open

dracut does not add all required libraries if /etc/ld.so.preload contains a missing library #2241

aafeijoo-suse opened this issue Feb 27, 2023 · 4 comments · Fixed by dracut-ng/dracut-ng#127 · May be fixed by #2243
Labels
bug Our bugs

Comments

@aafeijoo-suse
Copy link
Member

Describe the bug
If /etc/ld.so.preload contains a missing library, dracut does not add all the required libraries to the initrd.

Distribution used
openSUSE Tumbleweed

Dracut version
dracut 059+suse.360.g2e0ed5f7-1.1

Init system
systemd

To Reproduce

# echo "/usr/lib64/libfoo.so" > /etc/ld.so.preload
# dracut -f

Additional context
This issue is similar to the one fixed by #2193:

# ldd /usr/lib64/libfido2.so.1.12.0 
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffe9c1fc000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007faab19bd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007faab1400000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007faab198f000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007faab1986000)
	libz.so.1 => /lib64/libz.so.1 (0x00007faab196c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007faab1205000)
	/lib64/ld-linux-x86-64.so.2 (0x00007faab1a16000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.

dracut/src/install/dracut-install.c

Lines 605 to 606 in 1ddcb13

if (strstr(buf, "cannot be preloaded"))
break;

If we replace that break with a continue, dracut-install continues parsing the ldd output and the missing libraries are included to the initrd.

This code was added in 4916dfc2, is there any reason why dracut should not continue parsing the ldd output?

CC: @dtardon
@aafeijoo-suse aafeijoo-suse added the bug Our bugs label Feb 27, 2023
@LaszloGombos
Copy link
Collaborator

I think we should review all break cases and consider continue one-by-one in that function.

@dtardon
Copy link
Contributor

dtardon commented Feb 28, 2023

If we replace that break with a continue, dracut-install continues parsing the ldd output and the missing libraries are included to the initrd.

This code was added in 4916dfc2, is there any reason why dracut should not continue parsing the ldd output?

AFAIR there isn't any. I'm pretty sure I just copied the preceding check.

@aafeijoo-suse
Copy link
Member Author

I think we should review all break cases and consider continue one-by-one in that function.

We haven't had a complaint for years and now we receive 2 similar bug reports (#2190 upstream and this one at SUSE) in a month, good timing :)

AFAIR there isn't any. I'm pretty sure I just copied the preceding check.

Ok, thanks for your feedback. I'll test it a little more before submitting a PR.

aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Feb 28, 2023
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
88bfd78 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241
@aafeijoo-suse aafeijoo-suse linked a pull request Feb 28, 2023 that will close this issue
Open
3 tasks
@aafeijoo-suse
Copy link
Member Author

This is not a regression, it was reported for dracut-044, our oldest supported version.

@dracutng dracutng mentioned this issue Apr 6, 2024
Merged
3 tasks
@aafeijoo-suse aafeijoo-suse reopened this Apr 8, 2024
ReillyBrogan pushed a commit to getsolus/dracut that referenced this issue May 18, 2024
@aafeijoo-suse @LaszloGombos
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
ace9e1b 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 4, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
8ef5ca5 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 4, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
7990e9e 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 4, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
675b2ca 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 4, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
89d452e 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 4, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
677efd1 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
aafeijoo-suse added a commit to aafeijoo-suse/dracut that referenced this issue Jun 5, 2024
@aafeijoo-suse
fix(dracut-install): continue parsing if ldd prints "cannot be preloa…
a5c2b7c 
…ded"

When /etc/ld.so.preload contains a non-existing library, `ldd` prints the
following output:

```
> ldd /usr/lib64/libfido2.so.1.12.0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
	linux-vdso.so.1 (0x00007ffd477f5000)
	libcbor.so.0.10 => /lib64/libcbor.so.0.10 (0x00007f34062dd000)
	libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f3405e00000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007f34062af000)
	libhidapi-hidraw.so.0 => /lib64/libhidapi-hidraw.so.0 (0x00007f34062a6000)
	libz.so.1 => /lib64/libz.so.1 (0x00007f340628c000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3405c05000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3406336000)
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
> echo $?
0
ERROR: ld.so: object '/usr/lib64/libfoo.so' from /etc/ld.so.preload cannot be preloaded (cannot open shared object file): ignored.
```

If `dracut-install` stops parsing the `ldd` output, the initrd will not contain
all the required dependencies.

Fixes issue dracutdevs#2241

(cherry picked from commit dracut-ng/dracut-ng@ace9e1b)

bsc#1208690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Our bugs
Projects
None yet
Milestone
No milestone
3 participants
@LaszloGombos @dtardon @aafeijoo-suse