-
Notifications
You must be signed in to change notification settings - Fork 113
ece medium and large installation instructions improved #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
deploy-manage/deploy/cloud-enterprise/deploy-large-installation.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/cloud-enterprise/deploy-medium-installation.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🐅
Looks great! Just one suggestion.
…n.md Co-authored-by: David Kilfoyle <[email protected]>
Thanks for your comments @kilfoyle . I've realized that we had more bugs in the "large" doc, and I'll need to fix them before merging. In the "large installation", we forgot to remove the proxy role (which is also greyed-out in first host). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⛵
Looks superb @eedugon!
This PR fixes and improves ECE medium and large installation instructions.
Fixes:
Enhancements:
greyed out
in one of the hosts. It improves the reading flow.Closes https://github.com/elastic/cloud/issues/133321