found another exception irregularity synchronous calls with a connection pool with only ONE node did not throw maxretry but let the original exception bubble.

Author: Mpdreamz

src/Elasticsearch.Net/Connection/Transport.cs

@@ -32,6 +32,7 @@ public class Transport : ITransport
 		private readonly IConnectionPool _connectionPool;
 		private readonly IDateTimeProvider _dateTimeProvider;
 		private DateTime? _lastSniff;
+		private bool _throwMaxRetry;
 
 		public IConnectionConfigurationValues Settings { get { return ConfigurationValues; } }
 		public IElasticsearchSerializer Serializer { get { return _serializer; } }
@@ -47,6 +48,7 @@ public Transport(
 			this.Connection = connection ?? new HttpConnection(configurationValues);
 			this._serializer = serializer ?? new ElasticsearchDefaultSerializer();
 			this._connectionPool = this.ConfigurationValues.ConnectionPool;
+			this._throwMaxRetry = !(this._connectionPool is SingleNodeConnectionPool);
 
 			this._dateTimeProvider = dateTimeProvider ?? new DateTimeProvider();
 
@@ -362,7 +364,11 @@ private ElasticsearchResponse<T> DoRequest<T>(TransportRequestState<T> requestSt
 			{
 				requestState.SeenExceptions.Add(e);
 				if (maxRetries == 0 && retried == 0)
-					throw;
+				{
+					if (_throwMaxRetry)
+						new MaxRetryException(e);
+					else throw;
+				}
 				seenError = true;
 				return RetryRequest<T>(requestState);
 			}

src/Tests/Nest.Tests.Integration/Exceptions/ElasticsearchExceptionTests.cs

@@ -105,8 +105,44 @@ public void WebException_WithThrowingClient_ThrowsMappedException()
 			var e = Assert.Throws<ElasticsearchServerException>(() => client.Search<ElasticsearchProject>(s => s.QueryRaw(@"{ ""badjson"" : {} }")));
 			e.ExceptionType.Should().Contain("SearchPhaseExecutionException");
 		}
-
-
+		
+		[Test]
+		public void ConnectionPool_SingleNode_PingExceptionThrowsMaxRetry()
+		{
+			var uris = new []
+			{
+				ElasticsearchConfiguration.CreateBaseUri(9201),
+			};
+			var connectionPool = new StaticConnectionPool(uris);
+			var client = new ElasticClient(new ConnectionSettings(connectionPool)
+				.SetTimeout(1000)
+			);
+			var e = Assert.Throws<MaxRetryException>(() =>
+			{
+				var result = client.Search<ElasticsearchProject>(s => s.MatchAll());
+				result.IsValid.Should().BeFalse();
+			});
+			e.Should().NotBeNull();
+		}
+	
+		[Test]
+		public void ConnectionPool_SingleNode_PingExceptionThrowsMaxRetry_Async()
+		{
+			var uris = new []
+			{
+				ElasticsearchConfiguration.CreateBaseUri(9201),
+			};
+			var connectionPool = new StaticConnectionPool(uris);
+			var client = new ElasticClient(new ConnectionSettings(connectionPool)
+				.SetTimeout(1000)
+			);
+			var e = Assert.Throws<MaxRetryException>(async () =>
+			{
+				var result = await client.SearchAsync<ElasticsearchProject>(s => s.MatchAll());
+				result.IsValid.Should().BeFalse();
+			});
+			e.Should().NotBeNull();
+		}
 		[Test]
 		public void ConnectionPool_DoesNotThrowOnServerExceptions_ThrowsMaxRetryException_OnDeadNodes()
 		{