Skip to content

Commit aa6e1ad

Browse files
authored
Add comments pointing to Azure creds renewal docs (#127897)
These were some of the places I looked for information about renewal. Leaving a hint for next time.
1 parent 2d9fc30 commit aa6e1ad

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.buildkite/scripts/third-party-test-credentials.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ set -euo pipefail
77
# The second/lowercase export is what the tests expect/require
88

99
if [[ "${USE_3RD_PARTY_AZURE_CREDENTIALS:-}" == "true" ]]; then
10+
# These credentials expire periodically and must be manually renewed - the process is in the onboarding/process docs.
1011
json=$(vault read -format=json secret/ci/elastic-elasticsearch/migrated/azure_thirdparty_test_creds)
1112

1213
AZURE_STORAGE_ACCOUNT_SECRET=$(echo "$json" | jq -r .data.account_id)
@@ -19,6 +20,7 @@ if [[ "${USE_3RD_PARTY_AZURE_CREDENTIALS:-}" == "true" ]]; then
1920
fi
2021

2122
if [[ "${USE_3RD_PARTY_AZURE_SAS_CREDENTIALS:-}" == "true" ]]; then
23+
# These credentials expire periodically and must be manually renewed - the process is in the onboarding/process docs.
2224
json=$(vault read -format=json secret/ci/elastic-elasticsearch/migrated/azure_thirdparty_sas_test_creds)
2325

2426
AZURE_STORAGE_ACCOUNT_SECRET=$(echo "$json" | jq -r .data.account_id)

modules/repository-azure/src/internalClusterTest/java/org/elasticsearch/repositories/azure/AzureStorageCleanupThirdPartyTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@
4848
import static org.hamcrest.Matchers.equalTo;
4949
import static org.hamcrest.Matchers.not;
5050

51+
/**
52+
* These tests sometimes run against a genuine Azure endpoint with credentials obtained from Vault. These credentials expire periodically
53+
* and must be manually renewed; the process is in the onboarding/process docs.
54+
*/
5155
public class AzureStorageCleanupThirdPartyTests extends AbstractThirdPartyRepositoryTestCase {
5256
private static final Logger logger = LogManager.getLogger(AzureStorageCleanupThirdPartyTests.class);
5357
private static final boolean USE_FIXTURE = Booleans.parseBoolean(System.getProperty("test.azure.fixture", "true"));

0 commit comments

Comments
 (0)