ESQL: Add times to topn status #131555
Open
ESQL: Add times to topn status #131555
+79
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds times to the TopNOperator status, specifically the nanoseconds
spent receiving the values and the nanoseconds spent emitting the values:
```
{
"operator" : "TopNOperator[count=0/1000, elementTypes=[BYTES_REF, DOUBLE], encoders=[UTF8TopNEncoder, DefaultSortable], sortOrders=[SortOrder[channel=1, asc=false, nullsFirst=true]]]",
"status" : {
"receive_nanos" : 193415, <--- this row
"emit_nanos" : 61, <--- and this row
"occupied_rows" : 0,
"ram_bytes_used" : 4296,
"ram_used" : "4.1kb",
"pages_received" : 1,
"pages_emitted" : 1,
"rows_received" : 1000,
"rows_emitted" : 1000
}
}
```
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
reviewed
Jul 18, 2025
| @@ -548,9 +553,11 @@ public Page getOutput() { | |||
| if (output == null || output.hasNext() == false) { | |||
| return null; | |||
| } | |||
| long start = System.nanoTime(); | |||
There was a problem hiding this comment.
I think we should capture the emit time in finish() (toPages) method instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds times to the TopNOperator status, specifically the nanoseconds spent receiving the values and the nanoseconds spent emitting the values: