Skip to content

Commit 7bc813f

Browse files
authored
Merge pull request #23 from kapral18/docs/add_eui_and_styles
docs: update README with EUI and styled-components performance analysis
2 parents da70f97 + f74e947 commit 7bc813f

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

README.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,23 @@ that there is negligible algorithmic perf difference in performance between the
7373
<img src="./assets/macbook_hidden_true_before_after.png" width="100%" alt="Local macbook results" />
7474

7575
Another thing to keep in mind is that `hidden` option is only applicable to `ByRole` queries, and not to `ByLabelText` queries. So if you are using `ByLabelText` queries, you will not see any performance improvement from setting `defaultHidden` to true or individual `hidden` option to true.
76+
77+
## Updates
78+
79+
### EUI, styled-components and dense styling
80+
81+
Added `eui`, `styled-components` and some simulation of dense styling to the components to see how it affects the performance and whether hidden option has any effect on it.
82+
83+
Results:
84+
85+
**CI agent results**
86+
<img src="./assets/ci-agent-with-eui.png" width="100%" alt="CI agent results with EUI changes" />
87+
88+
**Local macbook results**
89+
<img src="./assets/local-macbook-with-eui.png" width="100%" alt="Local macbook results with EUI changes" />
90+
91+
### Change Conclusion
92+
93+
The results show that presence of EUI or styles doesn't affect the performance of the selectors significantly. The hidden option also doesn't have any effect on the performance of the selectors when EUI or styles are present.
94+
95+
Algorithmic complexity of the selectors is the main factor that affects the performance of the selectors.

assets/ci-agent-with-eui.png

243 KB
Loading

assets/local-macbook-with-eui.png

264 KB
Loading

0 commit comments

Comments
 (0)