Added eslint rule for unused vars (#728)

rostyk-kanafotskyy · web-flow · commit c4a630bf0c65 · 2020-05-22T12:24:17.000-04:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -4,7 +4,8 @@
     "react/jsx-wrap-multilines": ["off"],
     "react/destructuring-assignment": ["off"],
     "react/jsx-boolean-value": ["off"],
-    "no-param-reassign": ["off"]
+    "no-param-reassign": ["off"],
+    "@typescript-eslint/no-unused-vars": "warn"
   },
   "settings": {
     "import/resolver": {
diff --git a/src/components/src/AddressForm/addressform.main.tsx b/src/components/src/AddressForm/addressform.main.tsx
@@ -172,7 +172,7 @@ class AddressFormMain extends Component<AddressFormMainProps, AddressFormMainSta
   async submitAddress(event) {
     event.preventDefault();
     const {
-      addressData, fetchData, onCloseModal, chosenShipping, selectactionShippingUri, selectactionBillingUri,
+      addressData, fetchData, onCloseModal, selectactionShippingUri, selectactionBillingUri,
     } = this.props;
     const {
       addressForm, firstName, lastName, address, extendedAddress, city, country, subCountry, postalCode, isShippingAddress, isBillingAddress,
diff --git a/src/components/src/AppHeader/appheader.main.tsx b/src/components/src/AppHeader/appheader.main.tsx
@@ -243,7 +243,6 @@ class AppHeaderMain extends Component<AppHeaderMainProps, AppHeaderMainState> {
       isOffline, cartData, isLoading, isSearchFocused, isBulkModalOpened, isDesktop, isLoggedInUser, multiCartData, totalQuantity,
     } = this.state;
     const {
-      checkedLocation,
       handleResetPassword,
       onCurrencyChange,
       onLocaleChange,
@@ -255,8 +254,6 @@ class AppHeaderMain extends Component<AppHeaderMainProps, AppHeaderMainState> {
       redirectToMainPage,
       appHeaderLinks,
       appHeaderLoginLinks,
-      appHeaderNavigationLinks,
-      appHeaderTopLinks,
       appModalLoginLinks,
     } = this.props;
     const availability = Boolean(cartData || multiCartData);
diff --git a/src/components/src/AppHeaderSearch/appheadersearch.main.tsx b/src/components/src/AppHeaderSearch/appheadersearch.main.tsx
@@ -57,7 +57,7 @@ class AppHeaderSearchMain extends Component<AppHeaderSearchMainProps, AppHeaderS
     this.search = this.search.bind(this);
   }
 
-  componentDidUpdate(prevProps) {
+  componentDidUpdate() {
     const { isFocused } = this.props;
 
     if (isFocused === true) {
diff --git a/src/components/src/B2bAccountList/b2b.accountlist.tsx b/src/components/src/B2bAccountList/b2b.accountlist.tsx
@@ -95,7 +95,6 @@ class B2bAccountList extends Component<B2bAccountMainProps, B2bAccountMainState>
         accountListData,
         accountName,
         registrationNumber,
-        getSubAccountData,
       } = this.props;
 
       const { showAccountsMobileMenu } = this.state;
diff --git a/src/components/src/B2bAddProductsModal/b2b.add.products.modal.tsx b/src/components/src/B2bAddProductsModal/b2b.add.products.modal.tsx
@@ -106,10 +106,6 @@ class AddProductsModal extends Component<AddProductsModalProps, AddProductsModal
     const arrayItems = dataItems
       .filter(item => item.code !== '')
       .map(item => ({ code: item.code, quantity: item.quantity }));
-    let totalQuantity = 0;
-    arrayItems.forEach((item) => {
-      totalQuantity += item.quantity;
-    });
     login().then(() => {
       const body: { [key: string]: any } = {};
       if (arrayItems) {
diff --git a/src/components/src/B2bEditAccount/b2b.editaccount.tsx b/src/components/src/B2bEditAccount/b2b.editaccount.tsx
@@ -147,7 +147,7 @@ class B2bEditAccount extends Component<B2bEditAccountProps, B2bEditAccountState>
           handleUpdate();
           this.setState({ isLoading: false });
         })
-        .catch((err) => {
+        .catch(() => {
           this.setState({ isLoading: false });
         });
     });
diff --git a/src/components/src/B2bEditAssociate/b2b.editassociate.tsx b/src/components/src/B2bEditAssociate/b2b.editassociate.tsx
@@ -80,7 +80,7 @@ class B2bEditAssociate extends Component<B2bEditAssociateProps, B2bEditAssociate
   }
 
   renderRoleSelection() {
-    const { rolesSelector, isSelf } = this.props;
+    const { rolesSelector } = this.props;
 
     const allAssociateRoles = [];
     if (rolesSelector) {
diff --git a/src/components/src/B2bSideMenu/b2b.sidemenu.tsx b/src/components/src/B2bSideMenu/b2b.sidemenu.tsx
@@ -20,7 +20,7 @@
  */
 
 import React, { Component } from 'react';
-import { Route, Link } from 'react-router-dom';
+import { Link } from 'react-router-dom';
 import intl from 'react-intl-universal';
 import './b2b.sidemenu.scss';
 
diff --git a/src/components/src/Bloomreach/bloomreach.appheadersearch.main.tsx b/src/components/src/Bloomreach/bloomreach.appheadersearch.main.tsx
@@ -19,7 +19,7 @@
  *
  */
 
-import React, { FormEvent, SyntheticEvent, Component } from 'react';
+import React, { SyntheticEvent, Component } from 'react';
 import { bloomreachSuggestionSearch } from '../utils/BloomreachSearchService';
 import './bloomreach.headersearch.main.scss';
 import { ReactComponent as SearchIcon } from '../../../images/header-icons/magnifying-glass.svg';
@@ -95,7 +95,7 @@ class BloomreachHeaderSearchMain extends Component<BloomreachHeaderSearchMainPro
     this.handleOnTouchEndOnSuggestionLiElement = this.handleOnTouchEndOnSuggestionLiElement.bind(this);
   }
 
-  componentDidUpdate(prevProps) {
+  componentDidUpdate() {
     const { isFocused } = this.props;
 
     if (isFocused === true) {
@@ -189,7 +189,7 @@ class BloomreachHeaderSearchMain extends Component<BloomreachHeaderSearchMainPro
         onKeyDown={this.liHandleKeyDown}
         onMouseUp={(e) => { this.search(e, suggestion.q); }}
         onTouchEnd={(e) => { this.handleOnTouchEndOnSuggestionLiElement(e, suggestion.q); }}
-        onTouchMove={(e) => { this.isTouchMoveEvent = true; }}
+        onTouchMove={() => { this.isTouchMoveEvent = true; }}
       >
         {suggestion.dq}
       </li>
diff --git a/src/components/src/CartCreate/cart.create.tsx b/src/components/src/CartCreate/cart.create.tsx
@@ -173,7 +173,7 @@ class CartCreate extends Component<CartCreateProps, CartCreateState> {
         body: JSON.stringify({ descriptor: { name: cartName } }),
       })
         .then(res => res.json())
-        .then((res) => {
+        .then(() => {
           this.fetchCartData(-1);
           handleCartsUpdate();
         })
@@ -347,7 +347,7 @@ class CartCreate extends Component<CartCreateProps, CartCreateState> {
         </p>
         <div className="btn-wrap">
           <button type="button" className="ep-btn cancel-btn" onClick={() => this.handleCancelEditCart(index, 0)}>{intl.get('cancel')}</button>
-          <button type="button" className="ep-btn ok-btn" onClick={event => this.handleDeleteCart(element, index)}>
+          <button type="button" className="ep-btn ok-btn" onClick={() => this.handleDeleteCart(element, index)}>
             {element.removeCartLoading ? (
               <div className="circularLoader" aria-label="Loading" />
             ) : (
diff --git a/src/components/src/ChatBot/chatbot.review.tsx b/src/components/src/ChatBot/chatbot.review.tsx
@@ -49,7 +49,7 @@ async function InvokeIntent(utterance) {
   return response;
 }
 
-const handleCompleteIntent = (err, confirmation) => {
+const handleCompleteIntent = (err) => {
   if (err) {
     // eslint-disable-next-line no-console
     console.error('Conversation failed...');
diff --git a/src/components/src/FacebookChat/facebookchat.main.tsx b/src/components/src/FacebookChat/facebookchat.main.tsx
@@ -74,7 +74,6 @@ class FacebookChat extends Component<FacebookChatProps, {}> {
   }
 
   render() {
-    const { config } = this.props;
     return (
       <div>
         <div id="fb-root" />
diff --git a/src/components/src/ImageContainer/image.container.tsx b/src/components/src/ImageContainer/image.container.tsx
@@ -60,11 +60,11 @@ const ImageContainer: React.FC<ImageContainerProps> = (props) => {
   const [error, setError] = useState(false);
   const [fallbackImgUrl, setFallbackImgUrl] = useState(imgUrl);
 
-  const handlePictureError = (e) => {
+  const handlePictureError = () => {
     setError(true);
   };
 
-  const handleImgError = (e) => {
+  const handleImgError = () => {
     if (isSkuImage) {
       setFallbackImgUrl(imgPlaceholder);
     } else {
@@ -84,13 +84,13 @@ const ImageContainer: React.FC<ImageContainerProps> = (props) => {
             type={`image/${type}`}
           />
         ))}
-        <img className={imgClassName} alt={imgAlt} src={fallbackImgUrl} key={fileName} onLoad={onLoadData} onError={e => handlePictureError(e)} />
+        <img className={imgClassName} alt={imgAlt} src={fallbackImgUrl} key={fileName} onLoad={onLoadData} onError={() => handlePictureError()} />
       </picture>
     );
   }
 
   if (fallbackImgUrl) {
-    return (<img className={imgClassName} alt={imgAlt} src={fallbackImgUrl} onLoad={onLoadData} onError={e => handleImgError(e)} />);
+    return (<img className={imgClassName} alt={imgAlt} src={fallbackImgUrl} onLoad={onLoadData} onError={() => handleImgError()} />);
   }
 
   return null;
diff --git a/src/components/src/PaymentForm/paymentform.main.tsx b/src/components/src/PaymentForm/paymentform.main.tsx
@@ -173,7 +173,7 @@ class PaymentFormMain extends Component<PaymentFormMainProps, PaymentFormMainSta
     }
   }
 
-  async componentDidUpdate(prevProps, prevState) {
+  async componentDidUpdate(prevProps) {
     const { defaultPostSelection } = this.props;
 
     if (defaultPostSelection !== prevProps.defaultPostSelection) {
diff --git a/src/components/src/PaymentSelectorMain/paymentselector.main.tsx b/src/components/src/PaymentSelectorMain/paymentselector.main.tsx
@@ -332,7 +332,7 @@ class PaymentSelectorMain extends Component<PaymentSelectorMainProps, PaymentSel
   render() {
     const { openNewPaymentModal, isLoading } = this.state;
     const {
-      onChange, disableAddPayment, shouldPostToProfile, showSaveToProfileOption, paymentInstrumentSelector,
+      onChange, disableAddPayment, shouldPostToProfile, showSaveToProfileOption,
     } = this.props;
 
     return (
diff --git a/src/components/src/ProductDisplayItem/productdisplayitem.main.tsx b/src/components/src/ProductDisplayItem/productdisplayitem.main.tsx
@@ -150,7 +150,7 @@ class ProductDisplayItemMain extends Component<ProductDisplayItemMainProps, Prod
     this.fetchRequisitionListsData();
   }
 
-  async componentDidUpdate(prevProps, prevState) {
+  async componentDidUpdate(prevProps) {
     const { productId, isQuickView } = this.props;
     if (prevProps.productId !== productId) {
       try {
diff --git a/src/components/src/ProductDisplayItemDetails/productdisplayitem.details.tsx b/src/components/src/ProductDisplayItemDetails/productdisplayitem.details.tsx
@@ -467,7 +467,6 @@ class ProductDisplayItemDetails extends Component<ProductDisplayDetailsProps, Pr
   }
 
   handleQuantityChange(event) {
-    const { itemQuantity } = this.state;
     if (event.target.value === '') {
       this.setState({ itemQuantity: 1 });
     } else {
diff --git a/src/components/src/PurchaseOrderWidget/purchase.order.widget.tsx b/src/components/src/PurchaseOrderWidget/purchase.order.widget.tsx
@@ -56,7 +56,7 @@ class PurchaseOrderWidget extends React.Component<PurchaseOrderWidgetProps, Purc
   }
 
   // eslint-disable-next-line consistent-return
-  static getDerivedStateFromProps(props, state) {
+  static getDerivedStateFromProps(props) {
     const { orderPaymentData } = props;
 
     const chosen = PurchaseOrderWidget.getChosenFromOrderData(orderPaymentData);
diff --git a/src/components/src/PurchaseOrderWidgetModal/purchase.order.widget.modal.tsx b/src/components/src/PurchaseOrderWidgetModal/purchase.order.widget.modal.tsx
@@ -21,7 +21,6 @@
 
 import React from 'react';
 import intl from 'react-intl-universal';
-import _ from 'lodash';
 import Modal from 'react-responsive-modal';
 import { cortexFetch } from '../utils/Cortex';
 import Config from '../../../ep.config.json';
diff --git a/src/components/src/QuickOrder/quickorder.main.tsx b/src/components/src/QuickOrder/quickorder.main.tsx
@@ -55,9 +55,6 @@ interface QuickOrderMainState {
   },
   showFailedMessage: boolean,
   failedSubmit: boolean,
-  productDataInfo: {
-    [key: string]: any
-  },
   addToCartFailedMessage: string
 }
 
@@ -79,7 +76,6 @@ class QuickOrderMain extends Component<QuickOrderMainProps, QuickOrderMainState>
     this.state = {
       failedSubmit: false,
       productId: '',
-      productDataInfo: {},
       itemQuantity: 1,
       addToCartFailedMessage: '',
       isLoading: false,
@@ -159,14 +155,13 @@ class QuickOrderMain extends Component<QuickOrderMainProps, QuickOrderMainState>
       productId,
       itemQuantity,
       openModal,
-      productDataInfo,
       productItemInfo,
       showFailedMessage,
     } = this.state;
     const {
       isBuyItAgain, itemDetailLink, onMoveToCart, onConfiguratorAddToCart, itemName,
     } = this.props;
-    const orderModal = data => (
+    const orderModal = () => (
       <Modal open={openModal || false} onClose={this.handleModalClose} classNames={{ modal: 'buy-it-again-modal-content' }} showCloseIcon={false}>
         <div id="buy-it-again-modal">
           <div className="modal-content" id="simplemodal-container">
@@ -201,7 +196,7 @@ class QuickOrderMain extends Component<QuickOrderMainProps, QuickOrderMainState>
               {intl.get('buy-it-again')}
             </button>
           </div>
-          {orderModal(productDataInfo)}
+          {orderModal()}
           <div className="auth-feedback-container" id={`product_display_item_add_to_cart_feedback_container${itemName}`} data-i18n="">
             {addToCartFailedMessage}
           </div>
@@ -239,7 +234,7 @@ class QuickOrderMain extends Component<QuickOrderMainProps, QuickOrderMainState>
               </button>
             </div>
           </form>
-          {productItemInfo && orderModal(productItemInfo)}
+          {productItemInfo && orderModal()}
           <div className="auth-feedback-container failed-message" id="product_display_item_add_to_cart_feedback_container" data-i18n="">
             {showFailedMessage && intl.get('incorrect-sku')}
           </div>
diff --git a/src/components/src/VRProductDisplayItem/VRPanelContent.tsx b/src/components/src/VRProductDisplayItem/VRPanelContent.tsx
@@ -21,9 +21,7 @@
 import React from 'react';
 import './VRPanelContent.scss';
 
-interface VRPanelContentMainProps {}
-
-function VRPanelContent(props: VRPanelContentMainProps) {
+function VRPanelContent() {
   return (
     <div className="outer-html-texture">
       <div id="boxHTML" className="inner-html-texture">
diff --git a/src/components/src/VRProductDisplayItem/VRProductDisplayItem.tsx b/src/components/src/VRProductDisplayItem/VRProductDisplayItem.tsx
@@ -34,7 +34,7 @@ class VRProductDisplayItem extends Component<IVRComponentProps, IVRComponentStat
     return (/Safari/i).test(userAgent) && !(/Chrome/i).test(userAgent);
   }
 
-  static getDerivedStateFromProps(nextProps, prevState) {
+  static getDerivedStateFromProps() {
     if (/Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(navigator.userAgent)) {
       return {
         isMobile: true,
diff --git a/src/containers/b2b/Accounts.tsx b/src/containers/b2b/Accounts.tsx
@@ -41,9 +41,9 @@ enum MessageType {
 
 interface AccountsState {
   admins: any;
-  defaultBillingAddress: any;
+  /* defaultBillingAddress: any;
   defaultShippingAddress: any;
-  recentOrders: any;
+  recentOrders: any; */
   accounts: any;
   searchAccounts: string;
   isLoading: boolean;
@@ -89,7 +89,7 @@ export default class Accounts extends React.Component<RouteComponentProps, Accou
       isLoading: true,
       noSearchResults: false,
       showSearchLoader: false,
-      defaultBillingAddress: {
+      /* defaultBillingAddress: {
         name: 'Inez Larson',
         address: '198 Bendar Knoll',
         city: 'East Nicklaus',
@@ -134,7 +134,7 @@ export default class Accounts extends React.Component<RouteComponentProps, Accou
           orderTotal: '$2934.03',
           status: 'Processing',
         },
-      ],
+      ], */
       accounts: [],
       admins: [],
       searchAccounts: '',
@@ -330,13 +330,13 @@ export default class Accounts extends React.Component<RouteComponentProps, Accou
           }
 
           return result.json()
-            .catch(_ => Promise.reject(new Error(intl.get('general-upload-error'))))
+            .catch(() => Promise.reject(new Error(intl.get('general-upload-error'))))
             .then((parsedJson) => {
               const errorMsg = parsedJson.messages.map(m => intl.get(`backend-message-${m.id}`) || m['debug-message']).join(' ');
               return Promise.reject(new Error(errorMsg));
             });
         },
-        _ => Promise.reject(new Error(intl.get('general-upload-error'))),
+        () => Promise.reject(new Error(intl.get('general-upload-error'))),
       );
   }
 
@@ -358,9 +358,9 @@ export default class Accounts extends React.Component<RouteComponentProps, Accou
   render() {
     const {
       admins,
-      defaultBillingAddress,
+      /* defaultBillingAddress,
       defaultShippingAddress,
-      recentOrders,
+      recentOrders, */
       accounts,
       isLoading,
       searchAccounts,
diff --git a/src/containers/b2b/RequisitionPageMain.tsx b/src/containers/b2b/RequisitionPageMain.tsx
@@ -294,7 +294,7 @@ class RequisitionPageMain extends Component<RouteComponentProps<RequisitionPageM
           },
           body: JSON.stringify({ lineitems }),
         })
-        .then((res) => {
+        .then(() => {
           this.setState({
             multiSelectMode: false,
             selectedProducts: [],
@@ -364,7 +364,7 @@ class RequisitionPageMain extends Component<RouteComponentProps<RequisitionPageM
     });
   }
 
-  clearListNameField(event) {
+  clearListNameField() {
     this.setState({
       listName: '',
     });

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ class AppHeaderSearchMain extends Component<AppHeaderSearchMainProps, AppHeaderS`
`57`	`57`	`this.search = this.search.bind(this);`
`58`	`58`	`}`
`59`	`59`
`60`		`- componentDidUpdate(prevProps) {`
	`60`	`+ componentDidUpdate() {`
`61`	`61`	`const { isFocused } = this.props;`
`62`	`62`
`63`	`63`	`if (isFocused === true) {`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ class B2bEditAssociate extends Component<B2bEditAssociateProps, B2bEditAssociate`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`renderRoleSelection() {`
`83`		`- const { rolesSelector, isSelf } = this.props;`
	`83`	`+ const { rolesSelector } = this.props;`
`84`	`84`
`85`	`85`	`const allAssociateRoles = [];`
`86`	`86`	`if (rolesSelector) {`