Skip to content

Feature: Add configuable option for managing allow or deny list of providers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pa-eps opened this issue Aug 24, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pa-eps
Copy link
Contributor

pa-eps commented Aug 24, 2021

This feature request is to add config options to the plugin to exclusively manage the following:

  • a list of 3rd party providers that are allowed
  • a list of 3rd party providers that are not allowed

For example: if the plugin is configured with certain provides to be "not allowed", then the plugin won't contact those service providers for embeddable objects.

Things to consider:

  • What would be the behaviour when the plugin encounters this option?
    Exit with an error or just show warning? I think we should just write a warning and let remarkable process rest of the markdown contents.

  • What would be the replacement content in the generated html page?
    Leave the original URL as-is or remove it entirely from the page?

  • Do we need both "allowed" and "not allowed" list?
    Perhaps just one of them as an option is okay.

@pa-eps pa-eps added enhancement New feature or request good first issue Good for newcomers labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant