Skip to content

[FEATURE REQUEST] Allow ALL storeviews to generate a URL when triggered from product grid. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hexmage opened this issue Jul 25, 2024 · 0 comments

Comments

@Hexmage
Copy link

Hexmage commented Jul 25, 2024

If you select all store views on the product grid only the urls for storeviews that dont have an overwritten value get generated. Imo it should be that all storeviews should regenerate in this scenario.

Replacing:

        $stores = !is_null($storeId)
            ? [$this->storeManager->getStore($storeId)]
            : $this->storeManager->getStores(false);

With:

        $stores = !is_null($storeId) && $storeId !== 0
            ? [$this->storeManager->getStore($storeId)]
            : $this->storeManager->getStores(false);

Should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant