use existing target validation functions

Author: ruslandoga

lib/mint/http1.ex

@@ -978,6 +978,7 @@ defmodule Mint.HTTP1 do
   # Percent-encoding is not case sensitive so we have to account for lowercase and uppercase.
   @hex_characters ~c"0123456789abcdefABCDEF"
 
+  defp validate_target(<<>> = empty_target), do: {:error, {:invalid_request_target, empty_target}}
   defp validate_target(target), do: validate_target(target, target)
 
   defp validate_target(<<?%, char1, char2, rest::binary>>, original_target)

lib/mint/http1/request.ex

@@ -17,7 +17,6 @@ defmodule Mint.HTTP1.Request do
   end
 
   defp encode_request_line(method, target) do
-    validate_target!(target)
     [method, ?\s, target, " HTTP/1.1\r\n"]
   end
 
@@ -46,9 +45,6 @@ defmodule Mint.HTTP1.Request do
     [Integer.to_string(length, 16), "\r\n", chunk, "\r\n"]
   end
 
-  defp validate_target!("" = target), do: throw({:mint, {:invalid_target, target}})
-  defp validate_target!(_target), do: :ok
-
   defp validate_header_name!(name) do
     _ =
       for <<char <- name>> do

test/mint/http1/integration_test.exs

@@ -100,6 +100,12 @@ defmodule Mint.HTTP1.IntegrationTest do
 
       assert byte_size(merge_body(responses, request)) == 1024
     end
+
+    test "empty target" do
+      {:ok, conn} = HTTP1.connect(:http, "localhost", 8080)
+      assert {:error, _conn, %Mint.HTTPError{} = error} = HTTP1.request(conn, "GET", "", [], nil)
+      assert Exception.message(error) == ~s|invalid request target: ""|
+    end
   end
 
   describe "twitter.com" do

test/mint/http1/request_test.exs

@@ -42,11 +42,6 @@ defmodule Mint.HTTP1.RequestTest do
       assert Request.encode("GET", "/", [{"foo", "bar\r\n"}], nil) ==
                {:error, {:invalid_header_value, "foo", "bar\r\n"}}
     end
-
-    test "empty target" do
-      assert Request.encode("GET", "", [], nil) ==
-               {:error, {:invalid_target, ""}}
-    end
   end
 
   describe "encode_chunk/1" do