refactoring to use queries

[jeetelongname]

Hello!
I am currently working on intergrating tree sitter into doom emacs and I was writing a code forlding plugin for it, after I had gotten most of it done someone notified me of this package which made a lot of that work redundant.

The only problem I have is that the way you handle the "getting" of the range. its not terribly idiomatic compared to some other examples evil-textobj-tree-sitter, emacs-tree-sitter proper as well as all of the nvim tree sitter efforts, this makes this package an outlier in this regard.

I was wondering if you could provide some insight into why you have gone this route and if you would be open to a refactor which I can then work on.

Thanks!
Jeet

[jcs090218]

Hi, and sorry for the late reply!

I was wondering if you could provide some insight into why you have gone this route and if you would be open to a refactor which I can then work on.

This package was originally created by junyi-hou (repo here). I have gone this route due to my lack of knowledge on TreeSitter's queries. I do agree queries could be a better path, so any refactoring PR are welcome. :)

[jeetelongname]

Ok Ill have a look at the code. and start work on a PR

[jcs090218]

I have tried to go for this route, see #5 for progress.

[jeetelongname]

Hi sorry for my silence on the matter, I will start testing and see if there is anything to change, where did you get the queries for this? It should be said that nvim tree sitter uses a custom predicate called #make-range! which does not exist in emacs tree sitter

[jcs090218]

No worries! I was busy working on something else as well. :)

I got the queries directly from evil-textobj-tree-sitter repo. But like as I mentioned above, I would need to work on learning s-expression, which I am not very good at! Can you help me simplify those query files?

[jeetelongname]

Hi Jcs, Yeah I can look into them, nvim also has folding so it might be good to take those instead but ill look into it and provide a proper PR Regards, – *Jeetaditya Chatterjee* /Sent using my text editor/

[jcs090218]

I may have come to the conclusion, the queries implementation is simply too slow (Windows). If someone want to try it out, see #5.