Skip to content

fix: back to top button in docs #15231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
konopkja opened this issue Apr 3, 2025 · 5 comments · May be fixed by #15236 or #15328
Open
1 of 2 tasks

fix: back to top button in docs #15231

konopkja opened this issue Apr 3, 2025 · 5 comments · May be fixed by #15236 or #15328
Assignees
@heronimus
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing

Comments

@konopkja
Copy link
Contributor

konopkja commented Apr 3, 2025 •
edited
Loading

Describe the bug

The back to top button is broken

To reproduce

  1. Go to https://ethereum.org/en/developers/docs/intro-to-ethereum/
  2. Scroll down to bottom part with feedback buttons
  3. See error

Expected behavior

fix how it looks

Screenshots

Image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added the bug 🐛 Something isn't working label Apr 3, 2025
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 3, 2025
@konopkja konopkja added good first issue Good item to try if you're new to contributing dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Apr 3, 2025
@heronimus
Copy link

 Hi @konopkja, I’d like to give this issue a try.

heronimus added a commit to heronimus/ethereum-org-website that referenced this issue Apr 3, 2025
@heronimus
Fix back-to-top link translation id (close: ethereum#15231)
80d6d81
@heronimus heronimus linked a pull request Apr 3, 2025 that will close this issue
Open
@heronimus
Copy link

heronimus commented Apr 3, 2025 •
edited
Loading

Hi @konopkja,

I’d like to confirm my findings after reviewing the layout code:

  • The back-to-top link was already present but broken as of at least March 8, 2024 (/88f0dd7), on this preview link (visible only on narrow windows).
  • The current layout has two back-to-top links/buttons:
    • One above the feedback card, which this issue refers to.
    • Another in the footer, which is used globally across other non-developer documentation pages.

Image Image

Proposed Fix

  • I already fixed the broken text in my recently opened PR (fix: developer docs back-to-top link translation id (close: #15231) #15236) by ensuring the correct sentence/translation for the “Back to Top” text while maintaining the existing text style.
    Let me know if we’d prefer changing it to a button or if there’s already a Figma design for it.

  • Regarding the duplicate back-to-top buttons, since the footer version is globally used, modifying it now might affect other pages. The best approach would be to leave it as is and create a separate issue for further discussion.

@konopkja
Copy link
Contributor Author

konopkja commented Apr 3, 2025

Hi, the fix you created is good, ty <3!

Hamza110376 added a commit to Hamza110376/ethereum-org-website that referenced this issue Apr 22, 2025
@Hamza110376
Issue fixed related to back top top button
a31475a 
[Fixes ethereum#15231]
@Hamza110376 Hamza110376 linked a pull request Apr 22, 2025 that will close this issue
Open
6 tasks
@CodeLeom
Copy link

If this issue has been fixed, can it be closed? so we can tidy the place

@konopkja
Copy link
Contributor Author

If this issue has been fixed, can it be closed? so we can tidy the place

lets close it, once the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heronimus heronimus

Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing
Projects
None yet
Milestone
No milestone
3 participants
@heronimus @CodeLeom @konopkja