cmd/utils: always record preimages in dev mode (#31821)

mask-pp · jwasinger · web-flow · commit 52dbd206bb9e · 2025-05-15T15:32:20.000+08:00
Fix a todo: force-enable this in --dev mode

---------

Co-authored-by: jwasinger &lt;j-wasinger@hotmail.com&gt;
diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
@@ -1712,7 +1712,6 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 		}
 	}
 	if ctx.IsSet(VMEnableDebugFlag.Name) {
-		// TODO(fjl): force-enable this in --dev mode
 		cfg.EnablePreimageRecording = ctx.Bool(VMEnableDebugFlag.Name)
 	}
 
@@ -1761,6 +1760,7 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
 	case ctx.Bool(DeveloperFlag.Name):
 		cfg.NetworkId = 1337
 		cfg.SyncMode = ethconfig.FullSync
+		cfg.EnablePreimageRecording = true
 		// Create new developer account or reuse existing one
 		var (
 			developer  accounts.Account

Original file line number	Diff line number	Diff line change
`@@ -1712,7 +1712,6 @@ func SetEthConfig(ctx cli.Context, stack node.Node, cfg *ethconfig.Config) {`
`1712`	`1712`	`}`
`1713`	`1713`	`}`
`1714`	`1714`	`if ctx.IsSet(VMEnableDebugFlag.Name) {`
`1715`		`- // TODO(fjl): force-enable this in --dev mode`
`1716`	`1715`	`cfg.EnablePreimageRecording = ctx.Bool(VMEnableDebugFlag.Name)`
`1717`	`1716`	`}`
`1718`	`1717`
`@@ -1761,6 +1760,7 @@ func SetEthConfig(ctx cli.Context, stack node.Node, cfg *ethconfig.Config) {`
`1761`	`1760`	`case ctx.Bool(DeveloperFlag.Name):`
`1762`	`1761`	`cfg.NetworkId = 1337`
`1763`	`1762`	`cfg.SyncMode = ethconfig.FullSync`
	`1763`	`+ cfg.EnablePreimageRecording = true`
`1764`	`1764`	`// Create new developer account or reuse existing one`
`1765`	`1765`	`var (`
`1766`	`1766`	`developer accounts.Account`