Connection pool #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be all ok |
korotovsky
force-pushed
the
2.0.x-connectionPool
branch
from
76a189e to
86cb0b1
Compare
| @@ -58,7 +60,7 @@ private function loadAmqpTransport(array $config, ContainerBuilder $container) | |||
| $this->loader->load('transport/amqp/tracer.xml'); | |||
| } | |||
|
|
|||
| $camelizeKey = function (array $config) { | |||
| $camelizeKey = function (array $config) use (&$camelizeKey) { | |||
There was a problem hiding this comment.
Ooops, It should be deleted :)
| @@ -67,15 +69,30 @@ private function loadAmqpTransport(array $config, ContainerBuilder $container) | |||
| return $camelized; | |||
| }; | |||
|
|
|||
| $camelizeKeyRecursive = function (array $config) use (&$camelizeKey) { | |||
There was a problem hiding this comment.
Why not just only have one recursive camelizeKey function? It seems a bit redundant to have them both.
There was a problem hiding this comment.
This is shouldn't apply for $exchanges and $queues recursively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.