Standardize subtyping error code into incompatible-type in react native and metro (#53312)

Summary:
Pull Request resolved: #53312

Changelog: [Internal]

Reviewed By: jbrown215

Differential Revision: D80400976

Author: SamChou19815

.flowconfig

@@ -75,6 +75,7 @@ module.system.haste.module_ref_prefix=m#
 
 react.runtime=automatic
 
+experimental.error_code_migration=new
 suppress_type=$FlowFixMe
 
 ban_spread_key_props=true

flow-typed/npm/ws_v7.x.x.js

@@ -21,7 +21,7 @@ declare type ws$PerMessageDeflateOptions = {
   maxPayload?: number,
 };
 
-/* $FlowFixMe[incompatible-extend] - Found with Flow v0.143.1 upgrade
+/* $FlowFixMe[incompatible-type] - Found with Flow v0.143.1 upgrade
  * "on" definition failing with string is incompatible with string literal */
 declare class ws$WebSocketServer extends events$EventEmitter {
   /**
@@ -141,7 +141,7 @@ declare type ws$UnexpectedResponseListener = (
 ) => mixed;
 declare type ws$UpgradeListener = (response: http$IncomingMessage<>) => mixed;
 
-/* $FlowFixMe[incompatible-extend] - Found with Flow v0.143.1 upgrade
+/* $FlowFixMe[incompatible-type] - Found with Flow v0.143.1 upgrade
  * "on" definition failing with string is incompatible with string literal */
 declare class ws$WebSocket extends events$EventEmitter {
   static Server: typeof ws$WebSocketServer;

jest/preprocessor.js

@@ -86,7 +86,7 @@ module.exports = {
         globalPrefix: '',
         hermesParser: true,
         hot: false,
-        // $FlowFixMe[incompatible-call] TODO: Remove when `inlineRequires` has been removed from metro-babel-transformer in OSS
+        // $FlowFixMe[incompatible-type] TODO: Remove when `inlineRequires` has been removed from metro-babel-transformer in OSS
         inlineRequires: true,
         minify: false,
         platform: '',
@@ -111,7 +111,7 @@ module.exports = {
 
     return generate(
       ast,
-      // $FlowFixMe[prop-missing] Error found when improving flow typing for libs
+      // $FlowFixMe[incompatible-type] Error found when improving flow typing for libs
       {
         code: true,
         comments: false,

packages/community-cli-plugin/src/commands/bundle/saveAssets.js

@@ -116,7 +116,7 @@ function copyAll(filesToCopy: CopiedFiles) {
         const src = queue.shift();
         // $FlowFixMe[incompatible-type]
         const dest = filesToCopy[src];
-        // $FlowFixMe[incompatible-call]
+        // $FlowFixMe[incompatible-type]
         copy(src, dest, copyNext);
       }
     };

packages/dev-middleware/src/__tests__/InspectorDebuggerUtils.js

@@ -105,8 +105,9 @@ export class DebuggerMock extends DebuggerAgent {
         : this.handle.mock.calls;
     // $FlowFixMe[incompatible-use]
     // $FlowFixMe[prop-missing]
+    // $FlowFixMe[incompatible-type]
     const [response] = newHandleCalls.find(args => args[0].id === message.id);
-    // $FlowFixMe[incompatible-return]
+    // $FlowFixMe[incompatible-type]
     // $FlowFixMe[incompatible-indexer]
     return response;
   }

packages/dev-middleware/src/__tests__/InspectorDeviceUtils.js

@@ -152,12 +152,12 @@ export class DeviceMock extends DeviceAgent {
         if (!payload) {
           return;
         }
-        // $FlowFixMe[incompatible-call] TODO(moti) Figure out the right way to type maybePayload generically
+        // $FlowFixMe[incompatible-type] TODO(moti) Figure out the right way to type maybePayload generically
         this.send({event, payload});
       });
       return;
     }
-    // $FlowFixMe[incompatible-call] TODO(moti) Figure out the right way to type maybePayload generically
+    // $FlowFixMe[incompatible-type] TODO(moti) Figure out the right way to type maybePayload generically
     this.send({event, payload: maybePayload});
   }
 }

packages/dev-middleware/src/__tests__/InspectorProtocolUtils.js

@@ -66,7 +66,7 @@ export async function sendFromTargetToDebugger<Message: CdpMessageFromTarget>(
       : debugger_.handle.mock.calls;
   // $FlowFixMe[incompatible-type]
   const [receivedMessage]: [Message] = newHandleCalls.find(
-    // $FlowFixMe[incompatible-call]
+    // $FlowFixMe[incompatible-type]
     (call: [Message]) => call[0].method === message.method,
   );
   return receivedMessage;
@@ -103,7 +103,7 @@ export async function sendFromDebuggerToTarget<Message: CdpMessageToTarget>(
     // $FlowFixMe[incompatible-use]
     call => call[0].wrappedEvent.id === message.id,
   );
-  // $FlowFixMe[incompatible-return]
+  // $FlowFixMe[incompatible-type]
   return receivedMessage.wrappedEvent;
 }
 

packages/dev-middleware/src/__tests__/ServerUtils.js

@@ -93,7 +93,7 @@ export async function createServer(options: CreateServerOptions): Promise<{
     );
     httpServer = https.createServer(
       {cert, key},
-      // $FlowFixMe[incompatible-call] The types for `connect` and `https` are subtly incompatible as written.
+      // $FlowFixMe[incompatible-type] The types for `connect` and `https` are subtly incompatible as written.
       app,
     );
   } else {

packages/dev-middleware/src/__tests__/getBaseUrlFromRequest-test.js

@@ -40,7 +40,7 @@ function makeRequest(
   host: ?string,
   encrypted: boolean,
 ): http$IncomingMessage<> | http$IncomingMessage<tls$TLSSocket> {
-  // $FlowFixMe[incompatible-return] Partial mock of request
+  // $FlowFixMe[incompatible-type] Partial mock of request
   return {
     socket: encrypted ? {encrypted: true} : {},
     headers: host != null ? {host} : {},

packages/dev-middleware/src/createDevMiddleware.js

@@ -81,7 +81,7 @@ export default function createDevMiddleware({
   projectRoot,
   serverBaseUrl,
   logger,
-  // $FlowFixMe[prop-missing]
+  // $FlowFixMe[incompatible-type]
   unstable_browserLauncher = DefaultBrowserLauncher,
   unstable_eventReporter,
   unstable_experiments: experimentConfig = {},