Remove pluggable-libs submodule and cleanup (#433)

Author: PraveenMudalgeri

patterns/behavioral/memento.py

@@ -47,15 +47,18 @@ def Transactional(method):
 
     :param method: The function to be decorated.
     """
+
     def transaction(obj, *args, **kwargs):
         state = memento(obj)
         try:
             return method(obj, *args, **kwargs)
         except Exception as e:
             state()
             raise e
+
     return transaction
 
+
 class NumObj:
     def __init__(self, value):
         self.value = value

patterns/behavioral/servant.py

@@ -19,22 +19,26 @@
 References:
 - https://en.wikipedia.org/wiki/Servant_(design_pattern)
 """
+
 import math
 
+
 class Position:
     """Representation of a 2D position with x and y coordinates."""
 
     def __init__(self, x, y):
         self.x = x
         self.y = y
 
+
 class Circle:
     """Representation of a circle defined by a radius and a position."""
 
     def __init__(self, radius, position: Position):
         self.radius = radius
         self.position = position
 
+
 class Rectangle:
     """Representation of a rectangle defined by width, height, and a position."""
 
@@ -65,7 +69,7 @@ def calculate_area(shape):
             ValueError: If the shape type is unsupported.
         """
         if isinstance(shape, Circle):
-            return math.pi * shape.radius ** 2
+            return math.pi * shape.radius**2
         elif isinstance(shape, Rectangle):
             return shape.width * shape.height
         else:

patterns/other/blackboard.py

@@ -15,6 +15,7 @@
 
 class AbstractExpert(ABC):
     """Abstract class for experts in the blackboard system."""
+
     @abstractmethod
     def __init__(self, blackboard) -> None:
         self.blackboard = blackboard
@@ -31,6 +32,7 @@ def contribute(self) -> None:
 
 class Blackboard:
     """The blackboard system that holds the common state."""
+
     def __init__(self) -> None:
         self.experts: list = []
         self.common_state = {
@@ -46,6 +48,7 @@ def add_expert(self, expert: AbstractExpert) -> None:
 
 class Controller:
     """The controller that manages the blackboard system."""
+
     def __init__(self, blackboard: Blackboard) -> None:
         self.blackboard = blackboard
 
@@ -63,6 +66,7 @@ def run_loop(self):
 
 class Student(AbstractExpert):
     """Concrete class for a student expert."""
+
     def __init__(self, blackboard) -> None:
         super().__init__(blackboard)
 
@@ -79,6 +83,7 @@ def contribute(self) -> None:
 
 class Scientist(AbstractExpert):
     """Concrete class for a scientist expert."""
+
     def __init__(self, blackboard) -> None:
         super().__init__(blackboard)
 

patterns/structural/mvc.py

@@ -11,6 +11,7 @@
 
 class Model(ABC):
     """The Model is the data layer of the application."""
+
     @abstractmethod
     def __iter__(self) -> Any:
         pass
@@ -29,6 +30,7 @@ def item_type(self) -> str:
 
 class ProductModel(Model):
     """The Model is the data layer of the application."""
+
     class Price(float):
         """A polymorphic way to pass a float with a particular
         __str__ functionality."""
@@ -56,12 +58,15 @@ def get(self, product: str) -> dict:
 
 class View(ABC):
     """The View is the presentation layer of the application."""
+
     @abstractmethod
     def show_item_list(self, item_type: str, item_list: list) -> None:
         pass
 
     @abstractmethod
-    def show_item_information(self, item_type: str, item_name: str, item_info: dict) -> None:
+    def show_item_information(
+        self, item_type: str, item_name: str, item_info: dict
+    ) -> None:
         """Will look for item information by iterating over key,value pairs
         yielded by item_info.items()"""
         pass
@@ -73,6 +78,7 @@ def item_not_found(self, item_type: str, item_name: str) -> None:
 
 class ConsoleView(View):
     """The View is the presentation layer of the application."""
+
     def show_item_list(self, item_type: str, item_list: list) -> None:
         print(item_type.upper() + " LIST:")
         for item in item_list:
@@ -84,7 +90,9 @@ def capitalizer(string: str) -> str:
         """Capitalizes the first letter of a string and lowercases the rest."""
         return string[0].upper() + string[1:].lower()
 
-    def show_item_information(self, item_type: str, item_name: str, item_info: dict) -> None:
+    def show_item_information(
+        self, item_type: str, item_name: str, item_info: dict
+    ) -> None:
         """Will look for item information by iterating over key,value pairs"""
         print(item_type.upper() + " INFORMATION:")
         printout = "Name: %s" % item_name
@@ -99,6 +107,7 @@ def item_not_found(self, item_type: str, item_name: str) -> None:
 
 class Controller:
     """The Controller is the intermediary between the Model and the View."""
+
     def __init__(self, model_class: Model, view_class: View) -> None:
         self.model: Model = model_class
         self.view: View = view_class
@@ -124,15 +133,17 @@ def show_item_information(self, item_name: str) -> None:
 
 class Router:
     """The Router is the entry point of the application."""
+
     def __init__(self):
         self.routes = {}
 
     def register(
-            self,
-            path: str,
-            controller_class: type[Controller],
-            model_class: type[Model],
-            view_class: type[View]) -> None:
+        self,
+        path: str,
+        controller_class: type[Controller],
+        model_class: type[Model],
+        view_class: type[View],
+    ) -> None:
         model_instance: Model = model_class()
         view_instance: View = view_class()
         self.routes[path] = controller_class(model_instance, view_instance)
@@ -184,7 +195,7 @@ def main():
     controller: Controller = router.resolve(argv[1])
 
     action: str = str(argv[2]) if len(argv) > 2 else ""
-    args: str = ' '.join(map(str, argv[3:])) if len(argv) > 3 else ""
+    args: str = " ".join(map(str, argv[3:])) if len(argv) > 3 else ""
 
     if hasattr(controller, action):
         command = getattr(controller, action)
@@ -201,4 +212,5 @@ def main():
         print(f"Command {action} not found in the controller.")
 
     import doctest
+
     doctest.testmod()

tests/behavioral/test_publish_subscribe.py

@@ -48,19 +48,21 @@ def test_provider_shall_update_affected_subscribers_with_published_subscription(
         sub2 = Subscriber("sub 2 name", pro)
         sub2.subscribe("sub 2 msg 1")
         sub2.subscribe("sub 2 msg 2")
-        with patch.object(sub1, "run") as mock_subscriber1_run, patch.object(
-            sub2, "run"
-        ) as mock_subscriber2_run:
+        with (
+            patch.object(sub1, "run") as mock_subscriber1_run,
+            patch.object(sub2, "run") as mock_subscriber2_run,
+        ):
             pro.update()
             cls.assertEqual(mock_subscriber1_run.call_count, 0)
             cls.assertEqual(mock_subscriber2_run.call_count, 0)
         pub.publish("sub 1 msg 1")
         pub.publish("sub 1 msg 2")
         pub.publish("sub 2 msg 1")
         pub.publish("sub 2 msg 2")
-        with patch.object(sub1, "run") as mock_subscriber1_run, patch.object(
-            sub2, "run"
-        ) as mock_subscriber2_run:
+        with (
+            patch.object(sub1, "run") as mock_subscriber1_run,
+            patch.object(sub2, "run") as mock_subscriber2_run,
+        ):
             pro.update()
             expected_sub1_calls = [call("sub 1 msg 1"), call("sub 1 msg 2")]
             mock_subscriber1_run.assert_has_calls(expected_sub1_calls)

tests/behavioral/test_servant.py

@@ -7,18 +7,20 @@
 def circle():
     return Circle(3, Position(0, 0))
 
+
 @pytest.fixture
 def rectangle():
     return Rectangle(4, 5, Position(0, 0))
 
 
 def test_calculate_area(circle, rectangle):
-    assert GeometryTools.calculate_area(circle) == math.pi * 3 ** 2
+    assert GeometryTools.calculate_area(circle) == math.pi * 3**2
     assert GeometryTools.calculate_area(rectangle) == 4 * 5
 
     with pytest.raises(ValueError):
         GeometryTools.calculate_area("invalid shape")
 
+
 def test_calculate_perimeter(circle, rectangle):
     assert GeometryTools.calculate_perimeter(circle) == 2 * math.pi * 3
     assert GeometryTools.calculate_perimeter(rectangle) == 2 * (4 + 5)

tests/structural/test_bridge.py

@@ -8,9 +8,10 @@ class BridgeTest(unittest.TestCase):
     def test_bridge_shall_draw_with_concrete_api_implementation(cls):
         ci1 = DrawingAPI1()
         ci2 = DrawingAPI2()
-        with patch.object(ci1, "draw_circle") as mock_ci1_draw_circle, patch.object(
-            ci2, "draw_circle"
-        ) as mock_ci2_draw_circle:
+        with (
+            patch.object(ci1, "draw_circle") as mock_ci1_draw_circle,
+            patch.object(ci2, "draw_circle") as mock_ci2_draw_circle,
+        ):
             sh1 = CircleShape(1, 2, 3, ci1)
             sh1.draw()
             cls.assertEqual(mock_ci1_draw_circle.call_count, 1)
@@ -33,9 +34,10 @@ def test_bridge_shall_scale_both_api_circles_with_own_implementation(cls):
         sh2.scale(SCALE_FACTOR)
         cls.assertEqual(sh1._radius, EXPECTED_CIRCLE1_RADIUS)
         cls.assertEqual(sh2._radius, EXPECTED_CIRCLE2_RADIUS)
-        with patch.object(sh1, "scale") as mock_sh1_scale_circle, patch.object(
-            sh2, "scale"
-        ) as mock_sh2_scale_circle:
+        with (
+            patch.object(sh1, "scale") as mock_sh1_scale_circle,
+            patch.object(sh2, "scale") as mock_sh2_scale_circle,
+        ):
             sh1.scale(2)
             sh2.scale(2)
             cls.assertEqual(mock_sh1_scale_circle.call_count, 1)

tests/test_hsm.py

@@ -58,15 +58,14 @@ def test_given_standby_on_message_switchover_shall_set_active(cls):
         cls.assertEqual(isinstance(cls.hsm._current_state, Active), True)
 
     def test_given_standby_on_message_switchover_shall_call_hsm_methods(cls):
-        with patch.object(
-            cls.hsm, "_perform_switchover"
-        ) as mock_perform_switchover, patch.object(
-            cls.hsm, "_check_mate_status"
-        ) as mock_check_mate_status, patch.object(
-            cls.hsm, "_send_switchover_response"
-        ) as mock_send_switchover_response, patch.object(
-            cls.hsm, "_next_state"
-        ) as mock_next_state:
+        with (
+            patch.object(cls.hsm, "_perform_switchover") as mock_perform_switchover,
+            patch.object(cls.hsm, "_check_mate_status") as mock_check_mate_status,
+            patch.object(
+                cls.hsm, "_send_switchover_response"
+            ) as mock_send_switchover_response,
+            patch.object(cls.hsm, "_next_state") as mock_next_state,
+        ):
             cls.hsm.on_message("switchover")
             cls.assertEqual(mock_perform_switchover.call_count, 1)
             cls.assertEqual(mock_check_mate_status.call_count, 1)