Skip to content

[Question] TimedCircuitStats.getCurrentBucket() returns the previous bucket instead of current one after the reset() #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganesh-k-7817 opened this issue Feb 17, 2025 · 0 comments

Comments

@ganesh-k-7817
Copy link

After the reset() all the buckets were resetted and currentIndex is set to 0.

But we are returning the currentBucket (which could be something else not necessarily to be 0th bucket).

I think we should return buckets[currentIndex] after the reset(). However, since failures or successes will be captured in a different bucket only once, is it worth addressing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant