-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Imagen editing #15174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Imagen editing #15174
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback. |
Generated by 🚫 Danger |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces image editing capabilities to the Imagen model, including inpainting and outpainting. The changes are extensive, adding new public APIs, internal types, and utility functions for image manipulation. My review focuses on improving API consistency, robustness of image handling, error handling, and test coverage. Key suggestions include making the inpaintImage
and outpaintImage
APIs more consistent and safer, improving the robustness of image data processing, and enhancing the encoding logic for reference images to be more future-proof. I've also recommended expanding unit tests to cover failure scenarios.
Result of partnering with Gemini CLI after asking it to start from the Android implementation