fix: Stop upgrading http requests to https automatically from browser context #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised in firecamp-dev#243 Previously, it was not possible to make a http request from the web client as the request would be transparently upgraded to https. This was consequence of an applied content security policy header with a directive to upgrade insecure requests. This change removes this CSP tag, meaning http requests are no longer forcibly upgraded.
👷 Deploy request for staging-firecamp-dev pending review.Visit the deploys page to approve it
|
|
|
mdotwills
changed the title
mdotwills
referenced
this pull request
in Sebb955/firecamp
Jan 22, 2025
|
Prefer #253 over this approach, so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #243
Previously, it was not possible to make a http request from the web client as the request would be transparently upgraded to https. This was consequence of an applied content security policy header with a directive to upgrade insecure requests.
This change removes this CSP tag, meaning http requests are no longer forcibly upgraded.