Skip to content

Commit 3944ca9

Browse files
Address cookiecutter todos
Signed-off-by: Flora <[email protected]>
1 parent afe3742 commit 3944ca9

File tree

12 files changed

+5
-57
lines changed

12 files changed

+5
-57
lines changed

.github/ISSUE_TEMPLATE/bug.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ body:
5050
- Documentation (part:docs)
5151
- Unit, integration and performance tests (part:tests)
5252
- Build script, CI, dependencies, etc. (part:tooling)
53-
# TODO(cookiecutter): Add other parts
54-
# Please have in mind that that the part:xxx labels need to
55-
# be created in the GitHub repository.
5653
validations:
5754
required: true
5855
- type: textarea

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@ blank_issues_enabled: true
55
contact_links:
66
- name: Ask a question ❓
77
url: https://github.com/frequenz-floss/frequenz-reporting-python/discussions/new?category=support
8-
# TODO(cookiecutter): Make sure the GitHub repository has a discussion category "Support"
9-
# Rename the "Q&A" category to "Support" and change the emoji to 🆘 (SOS)
108
about: Use this if you are not sure how to do something, have installation problems, etc.

.github/keylabeler.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,3 @@ labelMappings:
1616
"part:tests": "part:tests"
1717
"part:tooling": "part:tooling"
1818
"part:❓": "part:❓"
19-
# TODO(cookiecutter): Add other parts
20-
# Please have in mind that that the part:xxx labels need to
21-
# be created in the GitHub repository.

.github/labeler.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# For more details on the configuration please see:
77
# https://github.com/marketplace/actions/labeler
88

9-
# TODO(cookiecutter): Add different parts of the source
109
# For example:
1110
#
1211
# "part:module":

.github/workflows/ci.yaml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ jobs:
4343
steps:
4444
- name: Setup Git
4545
uses: frequenz-floss/[email protected]
46-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
47-
# with:
48-
# username: ${{ secrets.GIT_USER }}
49-
# password: ${{ secrets.GIT_PASS }}
5046

5147
- name: Print environment (debug)
5248
run: env
@@ -128,10 +124,6 @@ jobs:
128124
steps:
129125
- name: Setup Git
130126
uses: frequenz-floss/[email protected]
131-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
132-
# with:
133-
# username: ${{ secrets.GIT_USER }}
134-
# password: ${{ secrets.GIT_PASS }}
135127

136128
- name: Fetch sources
137129
uses: actions/checkout@v4
@@ -235,10 +227,6 @@ jobs:
235227
steps:
236228
- name: Setup Git
237229
uses: frequenz-floss/[email protected]
238-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
239-
# with:
240-
# username: ${{ secrets.GIT_USER }}
241-
# password: ${{ secrets.GIT_PASS }}
242230

243231
- name: Fetch sources
244232
uses: actions/checkout@v4
@@ -274,10 +262,6 @@ jobs:
274262
steps:
275263
- name: Setup Git
276264
uses: frequenz-floss/[email protected]
277-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
278-
# with:
279-
# username: ${{ secrets.GIT_USER }}
280-
# password: ${{ secrets.GIT_PASS }}
281265

282266
- name: Fetch sources
283267
uses: actions/checkout@v4
@@ -315,10 +299,6 @@ jobs:
315299
steps:
316300
- name: Setup Git
317301
uses: frequenz-floss/[email protected]
318-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
319-
# with:
320-
# username: ${{ secrets.GIT_USER }}
321-
# password: ${{ secrets.GIT_PASS }}
322302

323303
- name: Fetch sources
324304
uses: actions/checkout@v4
@@ -361,10 +341,6 @@ jobs:
361341
steps:
362342
- name: Setup Git
363343
uses: frequenz-floss/[email protected]
364-
# TODO(cookiecutter): Uncomment this for projects with private dependencies
365-
# with:
366-
# username: ${{ secrets.GIT_USER }}
367-
# password: ${{ secrets.GIT_PASS }}
368344

369345
- name: Fetch sources
370346
uses: actions/checkout@v4

.github/workflows/release-notes-check.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ jobs:
2424
if: github.event_name == 'pull_request'
2525
uses: brettcannon/check-for-changed-files@871d7b8b5917a4f6f06662e2262e8ffc51dff6d1 # v1.2.1
2626
with:
27-
# TODO(cookiecutter): Uncomment the following line for private repositories, otherwise remove it
28-
# token: ${{ secrets.github_token }}
2927
file-pattern: "RELEASE_NOTES.md"
3028
prereq-pattern: "src/**"
3129
skip-label: "cmd:skip-release-notes"

CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
# Fallback owner.
55
# These are the default owners for everything in the repo, unless a later match
66
# takes precedence.
7-
# TODO(cookiecutter): Add more specific code-owners, check if the default is correct
87
* @frequenz-floss/api-reporting-team

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
A highlevel interface for the reporting API
1010

11-
TODO(cookiecutter): Improve the README file
12-
1311
## Supported Platforms
1412

1513
The following platforms are officially supported (tested):

docs/_scripts/macros.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,5 @@ def define_env(env: macros.MacrosPlugin) -> None:
7474
# https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#adding-annotations
7575
env.variables["code_annotation_marker"] = _CODE_ANNOTATION_MARKER
7676

77-
# TODO(cookiecutter): Add any other macros, variables and filters here.
78-
7977
# This hook needs to be done at the end of the `define_env` function.
8078
_hook_macros_plugin(env)

mkdocs.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@ site_author: "Frequenz Energy-as-a-Service GmbH"
88
copyright: "Copyright © 2024 Frequenz Energy-as-a-Service GmbH"
99
repo_name: "frequenz-reporting-python"
1010
repo_url: "https://github.com/frequenz-floss/frequenz-reporting-python"
11-
# TODO(cookiecutter): "main" is the GitHub repo default branch, you might want to update it
12-
# if the project uses a different default branch.
13-
edit_uri: "edit/main/docs/"
11+
edit_uri: "edit/v0.x.x/docs/"
1412
strict: true # Treat warnings as errors
1513

1614
# Build directories
1715
theme:
1816
name: "material"
19-
# TODO(cookiecutter): You might want to change the logo, the file is located in "docs/"
2017
logo: _img/logo.png
2118
favicon: _img/logo.png
2219
language: en
@@ -51,7 +48,6 @@ theme:
5148
name: Switch to light mode
5249

5350
extra:
54-
# TODO(cookiecutter): You probably want to update the social links
5551
social:
5652
- icon: fontawesome/brands/github
5753
link: https://github.com/frequenz-floss
@@ -117,8 +113,6 @@ plugins:
117113
show_symbol_type_toc: true
118114
signature_crossrefs: true
119115
import:
120-
# TODO(cookiecutter): You might want to add other external references here
121-
# See https://mkdocstrings.github.io/python/usage/#import for details
122116
- https://docs.python.org/3/objects.inv
123117
- https://typing-extensions.readthedocs.io/en/stable/objects.inv
124118
# Note this plugin must be loaded after mkdocstrings to be able to use macros

pyproject.toml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ name = "frequenz-reporting-python"
1414
description = "A highlevel interface for the reporting API"
1515
readme = "README.md"
1616
license = { text = "MIT" }
17-
keywords = ["frequenz", "python", "lib", "library", "frequenz-reporting", "reporting", "highlevel", "tooling", "api"]
18-
# TODO(cookiecutter): Remove and add more classifiers if appropriate
17+
keywords = ["frequenz", "python", "lib", "library", "reporting", "highlevel", "tooling", "api"]
1918
classifiers = [
2019
"Development Status :: 3 - Alpha",
2120
"Intended Audience :: Developers",
@@ -26,7 +25,6 @@ classifiers = [
2625
"Typing :: Typed",
2726
]
2827
requires-python = ">= 3.11, < 4"
29-
# TODO(cookiecutter): Remove and add more dependencies if appropriate
3028
dependencies = [
3129
"typing-extensions >= 4.5.0, < 5",
3230
]
@@ -36,7 +34,6 @@ dynamic = ["version"]
3634
name = "Frequenz Energy-as-a-Service GmbH"
3735
3836

39-
# TODO(cookiecutter): Remove and add more optional dependencies if appropriate
4037
[project.optional-dependencies]
4138
dev-flake8 = [
4239
"flake8 == 7.1.0",
@@ -55,7 +52,7 @@ dev-mkdocs = [
5552
"mkdocs-macros-plugin == 1.0.5",
5653
"mkdocs-material == 9.5.27",
5754
"mkdocstrings[python] == 0.25.1",
58-
"mkdocstrings-python == 1.10.5",
55+
"mkdocstrings-python == 1.10.8",
5956
"frequenz-repo-config[lib] == 0.10.0",
6057
]
6158
dev-mypy = [
@@ -166,7 +163,7 @@ packages = ["frequenz.reporting"]
166163
strict = true
167164

168165
[[tool.mypy.overrides]]
169-
module = ["mkdocs_macros.*", "sybil", "sybil.*"]
166+
module = ["mkdocs_macros.*"]
170167
ignore_missing_imports = true
171168

172169
[tool.setuptools_scm]

src/frequenz/reporting/__init__.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
# License: MIT
22
# Copyright © 2024 Frequenz Energy-as-a-Service GmbH
33

4-
"""A highlevel interface for the reporting API.
5-
6-
TODO(cookiecutter): Add a more descriptive module description.
7-
"""
4+
"""A highlevel interface for the reporting API."""
85

96

107
# TODO(cookiecutter): Remove this function

0 commit comments

Comments
 (0)