Skip to content

Commit 5c9a1c5

Browse files
authored
Add missing type hints to instance members (#809)
2 parents 8d3d4a5 + 2373184 commit 5c9a1c5

File tree

8 files changed

+43
-27
lines changed

8 files changed

+43
-27
lines changed

src/frequenz/sdk/microgrid/_data_pipeline.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ def __init__(
8888
"""
8989
from ..actor import ChannelRegistry
9090

91-
self._resampler_config = resampler_config
91+
self._resampler_config: ResamplerConfig = resampler_config
9292

93-
self._channel_registry = ChannelRegistry(name="Data Pipeline Registry")
93+
self._channel_registry: ChannelRegistry = ChannelRegistry(
94+
name="Data Pipeline Registry"
95+
)
9496

9597
self._data_sourcing_actor: _ActorInfo | None = None
9698
self._resampling_actor: _ActorInfo | None = None

src/frequenz/sdk/timeseries/_grid_frequency.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,12 @@ def __init__(
6969
),
7070
)
7171

72-
self._request_sender = data_sourcing_request_sender
73-
self._channel_registry = channel_registry
74-
self._source_component = source
75-
self._component_metric_request = create_request(
72+
self._request_sender: Sender[
73+
ComponentMetricRequest
74+
] = data_sourcing_request_sender
75+
self._channel_registry: ChannelRegistry = channel_registry
76+
self._source_component: Component = source
77+
self._component_metric_request: ComponentMetricRequest = create_request(
7678
self._source_component.component_id
7779
)
7880

src/frequenz/sdk/timeseries/battery_pool/_battery_pool_reference_store.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ def __init__( # pylint: disable=too-many-arguments
7474
battery pool. If None or empty, then all batteries from the microgrid
7575
will be used.
7676
"""
77+
self._batteries: frozenset[int]
7778
if batteries_id:
78-
self._batteries: frozenset[int] = frozenset(batteries_id)
79+
self._batteries = frozenset(batteries_id)
7980
else:
8081
self._batteries = self._get_all_batteries()
8182

@@ -87,18 +88,21 @@ def __init__( # pylint: disable=too-many-arguments
8788
self._update_battery_status(batteries_status_receiver)
8889
)
8990

90-
self._min_update_interval = min_update_interval
91+
self._min_update_interval: timedelta = min_update_interval
9192

92-
self._power_manager_requests_sender = power_manager_requests_sender
93-
self._power_manager_bounds_subscription_sender = (
94-
power_manager_bounds_subscription_sender
95-
)
93+
self._power_manager_requests_sender: Sender[
94+
_power_managing.Proposal
95+
] = power_manager_requests_sender
96+
97+
self._power_manager_bounds_subscription_sender: Sender[
98+
_power_managing.ReportRequest
99+
] = power_manager_bounds_subscription_sender
96100

97101
self._active_methods: dict[str, MetricAggregator[Any]] = {}
98102
self._power_bounds_subs: dict[str, asyncio.Task[None]] = {}
99103
self._namespace: str = f"battery-pool-{self._batteries}-{uuid.uuid4()}"
100104
self._power_distributing_namespace: str = f"power-distributor-{self._namespace}"
101-
self._channel_registry = channel_registry
105+
self._channel_registry: _channel_registry.ChannelRegistry = channel_registry
102106
self._formula_pool: FormulaEnginePool = FormulaEnginePool(
103107
self._namespace,
104108
self._channel_registry,

src/frequenz/sdk/timeseries/ev_charger_pool/_ev_charger_pool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def __init__(
9999
microgrid API, if no new calls to `set_bounds` have been made.
100100
"""
101101
self._channel_registry: ChannelRegistry = channel_registry
102-
self._repeat_interval = repeat_interval
102+
self._repeat_interval: timedelta = repeat_interval
103103
self._resampler_subscription_sender: Sender[
104104
ComponentMetricRequest
105105
] = resampler_subscription_sender

src/frequenz/sdk/timeseries/formula_engine/_formula_engine_pool.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,11 @@ def __init__(
4444
resampler_subscription_sender: A sender for sending metric requests to the
4545
resampling actor.
4646
"""
47-
self._namespace = namespace
48-
self._channel_registry = channel_registry
49-
self._resampler_subscription_sender = resampler_subscription_sender
47+
self._namespace: str = namespace
48+
self._channel_registry: ChannelRegistry = channel_registry
49+
self._resampler_subscription_sender: Sender[
50+
ComponentMetricRequest
51+
] = resampler_subscription_sender
5052
self._string_engines: dict[str, FormulaEngine[Quantity]] = {}
5153
self._power_engines: dict[str, FormulaEngine[Power]] = {}
5254
self._current_engines: dict[str, FormulaEngine3Phase[Current]] = {}

src/frequenz/sdk/timeseries/formula_engine/_formula_generators/_formula_generator.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,12 @@ def __init__(
7272
resampling actor.
7373
config: configs for the formula generator.
7474
"""
75-
self._channel_registry = channel_registry
76-
self._resampler_subscription_sender = resampler_subscription_sender
77-
self._namespace = namespace
78-
self._config = config
75+
self._channel_registry: ChannelRegistry = channel_registry
76+
self._resampler_subscription_sender: Sender[
77+
ComponentMetricRequest
78+
] = resampler_subscription_sender
79+
self._namespace: str = namespace
80+
self._config: FormulaGeneratorConfig = config
7981

8082
def _get_builder(
8183
self,

src/frequenz/sdk/timeseries/formula_engine/_resampled_formula_builder.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,12 @@ def __init__( # pylint: disable=too-many-arguments
4848
formula is for generating power values, this would be
4949
`Power.from_watts`, for example.
5050
"""
51-
self._channel_registry = channel_registry
52-
self._resampler_subscription_sender = resampler_subscription_sender
53-
self._namespace = namespace
54-
self._metric_id = metric_id
51+
self._channel_registry: ChannelRegistry = channel_registry
52+
self._resampler_subscription_sender: Sender[
53+
ComponentMetricRequest
54+
] = resampler_subscription_sender
55+
self._namespace: str = namespace
56+
self._metric_id: ComponentMetricId = metric_id
5557
self._resampler_requests: list[ComponentMetricRequest] = []
5658
super().__init__(formula_name, create_method) # type: ignore[arg-type]
5759

src/frequenz/sdk/timeseries/logical_meter/_logical_meter.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,10 @@ def __init__(
8585
resampler_subscription_sender: A sender for sending metric requests to the
8686
resampling actor.
8787
"""
88-
self._channel_registry = channel_registry
89-
self._resampler_subscription_sender = resampler_subscription_sender
88+
self._channel_registry: ChannelRegistry = channel_registry
89+
self._resampler_subscription_sender: Sender[
90+
ComponentMetricRequest
91+
] = resampler_subscription_sender
9092

9193
# Use a randomly generated uuid to create a unique namespace name for the local
9294
# meter to use when communicating with the resampling actor.

0 commit comments

Comments
 (0)