Skip to content

Commit 5a90913

Browse files
authored
Remove clean and no-daemon (#903)
We start from a clean slate on CI so running clean only adds time to the jobs. Also it is always recommended to use the daemon especially when running multiple jobs in order to speed up the build.
1 parent 1d9ce85 commit 5a90913

File tree

4 files changed

+10
-24
lines changed

4 files changed

+10
-24
lines changed

.github/workflows/pre-merge.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
if: always()
4646

4747
- name: Build the Debug variant
48-
run: ./gradlew assembleDebug --no-daemon
48+
run: ./gradlew assembleDebug
4949

5050
- name: Build the Release variant
51-
run: ./gradlew assembleRelease --no-daemon
51+
run: ./gradlew assembleRelease

Makefile

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
1-
.PHONY: format clean preMerge stop all
1+
.PHONY: format preMerge all
22

33
format:
44
./gradlew spotlessApply
55

6-
clean:
7-
./gradlew clean
8-
96
preMerge:
107
./gradlew preMerge --continue
118

12-
# We stop gradle at the end to make sure the cache folders
13-
# don't contain any lock files and are free to be cached.
14-
stop:
15-
./gradlew --stop
16-
17-
all: stop clean format preMerge
9+
all: format preMerge

plugin-build/Makefile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
.PHONY: clean compile all dist
2-
3-
clean:
4-
./gradlew clean
1+
.PHONY: compile all dist
52

63
compile:
74
./gradlew assemble
85

96
# build distribution artifacts
107
dist:
11-
./gradlew distZip --no-daemon --no-parallel
8+
./gradlew distZip --no-parallel
129

13-
all: clean compile dist
10+
all: compile dist
Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
.PHONY: clean compile all dist
2-
3-
clean:
4-
./gradlew clean
1+
.PHONY: compile all dist
52

63
compile:
74
./gradlew assemble
85

96
# build distribution artifacts
107
dist:
11-
./gradlew distZip --no-daemon --no-parallel
8+
./gradlew distZip --no-parallel
129

13-
all: clean compile dist
10+
all: compile dist

0 commit comments

Comments
 (0)