Skip to content

Commit 5573577

Browse files
✅ update post process test
1 parent a3b07e7 commit 5573577

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/sentry/feedback/usecases/create_feedback.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def should_filter_feedback(
278278
return False, None
279279

280280

281-
def generate_feedback_title(feedback_message: str, max_words: int = 10) -> str:
281+
def get_feedback_title(feedback_message: str, max_words: int = 10) -> str:
282282
"""
283283
Generate a descriptive title for user feedback issues.
284284
Format: "User Feedback: [first few words of message]"
@@ -376,7 +376,7 @@ def create_feedback_issue(
376376
event_id=event.get("event_id") or uuid4().hex,
377377
project_id=project_id,
378378
fingerprint=issue_fingerprint, # random UUID for fingerprint so feedbacks are grouped individually
379-
issue_title=generate_feedback_title(feedback_message),
379+
issue_title=get_feedback_title(feedback_message),
380380
subtitle=feedback_message,
381381
resource_id=None,
382382
evidence_data=evidence_data,

tests/sentry/feedback/usecases/test_create_feedback.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
FeedbackCreationSource,
1515
create_feedback_issue,
1616
fix_for_issue_platform,
17-
generate_feedback_title,
17+
get_feedback_title,
1818
is_in_feedback_denylist,
1919
shim_to_feedback,
2020
validate_issue_platform_event_schema,
@@ -1147,39 +1147,39 @@ def test_shim_to_feedback_missing_fields(default_project, monkeypatch):
11471147

11481148

11491149
@django_db_all
1150-
def test_generate_feedback_title():
1151-
"""Test the generate_feedback_title function with various message types."""
1150+
def test_get_feedback_title():
1151+
"""Test the get_feedback_title function with various message types."""
11521152

11531153
# Test normal short message
1154-
assert generate_feedback_title("Login button broken") == "User Feedback: Login button broken"
1154+
assert get_feedback_title("Login button broken") == "User Feedback: Login button broken"
11551155

11561156
# Test message with exactly 10 words (default max_words)
11571157
message_10_words = "This is a test message with exactly ten words total"
1158-
assert generate_feedback_title(message_10_words) == f"User Feedback: {message_10_words}"
1158+
assert get_feedback_title(message_10_words) == f"User Feedback: {message_10_words}"
11591159

11601160
# Test message with more than 10 words (should truncate)
11611161
long_message = "This is a very long feedback message that goes on and on and describes many different issues"
11621162
expected = "User Feedback: This is a very long feedback message that goes on..."
1163-
assert generate_feedback_title(long_message) == expected
1163+
assert get_feedback_title(long_message) == expected
11641164

11651165
# Test very short message
1166-
assert generate_feedback_title("Bug") == "User Feedback: Bug"
1166+
assert get_feedback_title("Bug") == "User Feedback: Bug"
11671167

11681168
# Test custom max_words parameter
11691169
message = "This is a test with custom word limit"
1170-
assert generate_feedback_title(message, max_words=3) == "User Feedback: This is a..."
1170+
assert get_feedback_title(message, max_words=3) == "User Feedback: This is a..."
11711171

11721172
# Test message that would create a title longer than 200 characters
11731173
very_long_message = "a" * 300 # 300 character message
1174-
result = generate_feedback_title(very_long_message)
1174+
result = get_feedback_title(very_long_message)
11751175
assert len(result) <= 200
11761176
assert result.endswith("...")
11771177
assert result.startswith("User Feedback: ")
11781178

11791179
# Test message with special characters
11801180
special_message = "The @login button doesn't work! It's broken & needs fixing."
11811181
expected_special = "User Feedback: The @login button doesn't work! It's broken & needs fixing."
1182-
assert generate_feedback_title(special_message) == expected_special
1182+
assert get_feedback_title(special_message) == expected_special
11831183

11841184

11851185
@django_db_all

tests/sentry/tasks/test_post_process.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from sentry.eventstore.models import Event
1919
from sentry.eventstore.processing import event_processing_store
2020
from sentry.eventstream.types import EventStreamEventType
21-
from sentry.feedback.usecases.create_feedback import FeedbackCreationSource, generate_feedback_title
21+
from sentry.feedback.usecases.create_feedback import FeedbackCreationSource, get_feedback_title
2222
from sentry.integrations.models.integration import Integration
2323
from sentry.integrations.source_code_management.commit_context import CommitInfo, FileBlameInfo
2424
from sentry.issues.auto_source_code_config.utils.platform import get_supported_platforms
@@ -2077,7 +2077,7 @@ def test_user_report_shims_to_feedback(self, mock_produce_occurrence_to_kafka):
20772077
assert mock_event_data["level"] == "error"
20782078

20792079
occurrence = mock_produce_occurrence_to_kafka.call_args_list[0][1]["occurrence"]
2080-
assert occurrence.issue_title == generate_feedback_title(
2080+
assert occurrence.issue_title == get_feedback_title(
20812081
mock_event_data["contexts"]["feedback"]["message"]
20822082
)
20832083

@@ -3216,7 +3216,7 @@ def create_event(
32163216
**{
32173217
"id": uuid.uuid4().hex,
32183218
"fingerprint": ["c" * 32],
3219-
"issue_title": generate_feedback_title(data["message"]),
3219+
"issue_title": get_feedback_title(data["message"]),
32203220
"subtitle": "it was bad",
32213221
"culprit": "api/123",
32223222
"resource_id": "1234",

0 commit comments

Comments
 (0)