Skip to content

Commit 8f875d9

Browse files
authored
fix(explore): Pass type properly for analytics (#90753)
1 parent 1e0810f commit 8f875d9

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

static/app/views/explore/hooks/usePaginationAnalytics.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,21 @@ import {useCallback} from 'react';
33
import {trackAnalytics} from 'sentry/utils/analytics';
44
import useOrganization from 'sentry/utils/useOrganization';
55

6-
export function usePaginationAnalytics(numResults: number) {
6+
export function usePaginationAnalytics(
7+
type: 'samples' | 'traces' | 'aggregates',
8+
numResults: number
9+
) {
710
const organization = useOrganization();
811

912
return useCallback(
1013
(direction: string) => {
1114
trackAnalytics('trace.explorer.table_pagination', {
1215
direction,
13-
type: 'traces',
16+
type,
1417
num_results: numResults,
1518
organization,
1619
});
1720
},
18-
[organization, numResults]
21+
[organization, numResults, type]
1922
);
2023
}

static/app/views/explore/tables/aggregatesTable.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,10 @@ export function AggregatesTable({
8585

8686
const palette = theme.chart.getColorPalette(numberOfRowsNeedingColor - 2); // -2 because getColorPalette artificially adds 1, I'm not sure why
8787

88-
const paginationAnalyticsEvent = usePaginationAnalytics(result.data?.length ?? 0);
88+
const paginationAnalyticsEvent = usePaginationAnalytics(
89+
'aggregates',
90+
result.data?.length ?? 0
91+
);
8992

9093
return (
9194
<Fragment>

static/app/views/explore/tables/spansTable.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,10 @@ export function SpansTable({spansTableResult}: SpansTableProps) {
6262
const {tags: numberTags} = useSpanTags('number');
6363
const {tags: stringTags} = useSpanTags('string');
6464

65-
const paginationAnalyticsEvent = usePaginationAnalytics(result.data?.length ?? 0);
65+
const paginationAnalyticsEvent = usePaginationAnalytics(
66+
'samples',
67+
result.data?.length ?? 0
68+
);
6669

6770
return (
6871
<Fragment>

static/app/views/explore/tables/tracesTable/index.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,10 @@ export function TracesTable({tracesTableResult}: TracesTableProps) {
6060
const showErrorState = !isPending && isError;
6161
const showEmptyState = !isPending && !showErrorState && (data?.data?.length ?? 0) === 0;
6262

63-
const paginationAnalyticsEvent = usePaginationAnalytics(data?.data?.length ?? 0);
63+
const paginationAnalyticsEvent = usePaginationAnalytics(
64+
'traces',
65+
data?.data?.length ?? 0
66+
);
6467

6568
return (
6669
<Fragment>

0 commit comments

Comments
 (0)