ref: fix more schema drift by setting more db_defaults (#90327)

<!-- Describe your PR here. -->

Author: asottile-sentry

migrations_lockfile.txt

@@ -21,7 +21,7 @@ remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0004_index_together
 
-sentry: 0868_delete_group_open_periods
+sentry: 0869_fix_drift_db_default_pt2
 
 social_auth: 0002_default_auto_field
 

src/sentry/hybridcloud/models/outbox.py

@@ -11,6 +11,7 @@
 from django import db
 from django.db import OperationalError, connections, models, router, transaction
 from django.db.models import Count, Max, Min
+from django.db.models.functions import Now
 from django.db.transaction import Atomic
 from django.utils import timezone
 from sentry_sdk.tracing import Span
@@ -177,7 +178,9 @@ class Meta:
     scheduled_for = models.DateTimeField(null=False, default=THE_PAST)
 
     # Initial creation date for the outbox which should not be modified. Used for lag time calculation.
-    date_added = models.DateTimeField(null=False, default=timezone.now, editable=False)
+    date_added = models.DateTimeField(
+        null=False, default=timezone.now, db_default=Now(), editable=False
+    )
 
     def last_delay(self) -> datetime.timedelta:
         return max(self.scheduled_for - self.scheduled_from, datetime.timedelta(seconds=1))

src/sentry/incidents/models/alert_rule.py

@@ -465,7 +465,9 @@ class AlertRuleTriggerAction(AbstractNotificationAction):
         dict[str, Any] | list[dict[str, Any]] | None,
     ] = JSONField(null=True)
     status = BoundedPositiveIntegerField(
-        default=ObjectStatus.ACTIVE, choices=ObjectStatus.as_choices()
+        default=ObjectStatus.ACTIVE,
+        db_default=ObjectStatus.ACTIVE,
+        choices=ObjectStatus.as_choices(),
     )
 
     class Meta:

src/sentry/migrations/0869_fix_drift_db_default_pt2.py

@@ -0,0 +1,120 @@
+# Generated by Django 5.1.7 on 2025-04-24 19:56
+
+import django.db.models.functions.datetime
+import django.utils.timezone
+from django.db import migrations, models
+
+import sentry.db.models.fields.bounded
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("sentry", "0868_delete_group_open_periods"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="alertruletriggeraction",
+            name="status",
+            field=sentry.db.models.fields.bounded.BoundedPositiveIntegerField(
+                db_default=0, default=0
+            ),
+        ),
+        migrations.AlterField(
+            model_name="authidentityreplica",
+            name="last_verified",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="controloutbox",
+            name="date_added",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+                editable=False,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="dashboardwidgetquery",
+            name="date_modified",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="dashboardwidgetqueryondemand",
+            name="date_added",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="group",
+            name="type",
+            field=sentry.db.models.fields.bounded.BoundedPositiveIntegerField(
+                db_default=1, db_index=True, default=1
+            ),
+        ),
+        migrations.AlterField(
+            model_name="perfstringindexer",
+            name="use_case_id",
+            field=models.CharField(db_default="performance", default="performance", max_length=120),
+        ),
+        migrations.AlterField(
+            model_name="projectdebugfile",
+            name="date_accessed",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="projectownership",
+            name="suspect_committer_auto_assignment",
+            field=models.BooleanField(db_default=False, default=False),
+        ),
+        migrations.AlterField(
+            model_name="regionoutbox",
+            name="date_added",
+            field=models.DateTimeField(
+                db_default=django.db.models.functions.datetime.Now(),
+                default=django.utils.timezone.now,
+                editable=False,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="user",
+            name="avatar_type",
+            field=models.PositiveSmallIntegerField(db_default=0, default=0),
+        ),
+        migrations.AlterField(
+            model_name="user",
+            name="avatar_url",
+            field=models.CharField(db_default=None, default=None, max_length=120, null=True),
+        ),
+        migrations.AlterField(
+            model_name="user",
+            name="is_unclaimed",
+            field=models.BooleanField(db_default=False, default=False),
+        ),
+    ]

src/sentry/models/authidentityreplica.py

@@ -3,6 +3,7 @@
 from typing import Any
 
 from django.db import models
+from django.db.models.functions import Now
 from django.utils import timezone
 
 from sentry.backup.scopes import RelocationScope
@@ -22,7 +23,7 @@ class AuthIdentityReplica(Model):
     auth_provider_id = HybridCloudForeignKey("sentry.AuthProvider", on_delete="CASCADE")
     ident = models.CharField(max_length=128)
     data: models.Field[dict[str, Any], dict[str, Any]] = JSONField()
-    last_verified = models.DateTimeField(default=timezone.now)
+    last_verified = models.DateTimeField(default=timezone.now, db_default=Now())
 
     # This represents the time at which this model was created, NOT the date_added of the original auth identity
     # we are replicating from.

src/sentry/models/dashboard_widget.py

@@ -5,6 +5,7 @@
 
 from django.contrib.postgres.fields import ArrayField as DjangoArrayField
 from django.db import models
+from django.db.models.functions import Now
 from django.utils import timezone
 from django.utils.translation import gettext_lazy
 
@@ -171,7 +172,7 @@ class DashboardWidgetQuery(Model):
     # Order of the widget query in the widget.
     order = BoundedPositiveIntegerField()
     date_added = models.DateTimeField(default=timezone.now)
-    date_modified = models.DateTimeField(default=timezone.now)
+    date_modified = models.DateTimeField(default=timezone.now, db_default=Now())
     # Whether this query is hidden from the UI, used by metric widgets
     is_hidden = models.BooleanField(default=False, db_default=False)
     # Used by Big Number to select aggregate displayed
@@ -222,7 +223,7 @@ class OnDemandExtractionState(models.TextChoices):
     spec_version = models.IntegerField(null=True)
     extraction_state = models.CharField(max_length=30, choices=OnDemandExtractionState.choices)
     date_modified = models.DateTimeField(default=timezone.now)
-    date_added = models.DateTimeField(default=timezone.now)
+    date_added = models.DateTimeField(default=timezone.now, db_default=Now())
 
     def can_extraction_be_auto_overridden(self):
         """Determines whether tasks can override extraction state"""

src/sentry/models/debugfile.py

@@ -16,6 +16,7 @@
 
 from django.db import models
 from django.db.models import Q
+from django.db.models.functions import Now
 from django.utils import timezone
 from symbolic.debuginfo import Archive, BcSymbolMap, Object, UuidMapping, normalize_debug_id
 from symbolic.exceptions import ObjectErrorUnsupportedObject, SymbolicError
@@ -130,7 +131,7 @@ class ProjectDebugFile(Model):
     debug_id = models.CharField(max_length=64, db_column="uuid")
     code_id = models.CharField(max_length=64, null=True)
     data: models.Field[dict[str, Any] | None, dict[str, Any] | None] = JSONField(null=True)
-    date_accessed = models.DateTimeField(default=timezone.now)
+    date_accessed = models.DateTimeField(default=timezone.now, db_default=Now())
 
     objects: ClassVar[ProjectDebugFileManager] = ProjectDebugFileManager()
 

src/sentry/models/group.py

@@ -597,7 +597,9 @@ class Group(Model):
         blank=True, null=True
     )
     short_id = BoundedBigIntegerField(null=True)
-    type = BoundedPositiveIntegerField(default=DEFAULT_TYPE_ID, db_index=True)
+    type = BoundedPositiveIntegerField(
+        default=DEFAULT_TYPE_ID, db_default=DEFAULT_TYPE_ID, db_index=True
+    )
     priority = models.PositiveSmallIntegerField(null=True)
     priority_locked_at = models.DateTimeField(null=True)
 

src/sentry/models/projectownership.py

@@ -48,7 +48,7 @@ class ProjectOwnership(Model):
     last_updated = models.DateTimeField(default=timezone.now)
     is_active = models.BooleanField(default=True)
     codeowners_auto_sync = models.BooleanField(default=True, null=True)
-    suspect_committer_auto_assignment = models.BooleanField(default=False)
+    suspect_committer_auto_assignment = models.BooleanField(default=False, db_default=False)
 
     class Meta:
         app_label = "sentry"

src/sentry/sentry_metrics/indexer/postgres/models.py

@@ -44,7 +44,11 @@ class Meta:
 @region_silo_model
 class PerfStringIndexer(BaseIndexer):
     __relocation_scope__ = RelocationScope.Excluded
-    use_case_id = models.CharField(max_length=120)
+    use_case_id = models.CharField(
+        max_length=120,
+        default=UseCaseKey.PERFORMANCE.value,
+        db_default=UseCaseKey.PERFORMANCE.value,
+    )
 
     class Meta:
         db_table = "sentry_perfstringindexer"