Skip to content

Commit cfd2b57

Browse files
authored
fix(eap): Normal mode should be default if no sampling mode defined (#94924)
The normal mode should be the default since it avoids timeouts better. All of the frontend uses the progressive query or they specify `NORMAL` mode. This allows us to clean up the code and assume normal mode by default, to remove any explicit passing down when unnecessary. Afaik no request requires `HIGH_ACCURACY` from the beginning by explicitly omitting the `samplingMode` param.
1 parent 090699d commit cfd2b57

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/sentry/search/eap/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def transform_column_to_expression(column: Column) -> Expression:
108108

109109
def validate_sampling(sampling_mode: SAMPLING_MODES | None) -> DownsampledStorageConfig:
110110
if sampling_mode is None:
111-
return DownsampledStorageConfig(mode=DownsampledStorageConfig.MODE_HIGHEST_ACCURACY)
111+
return DownsampledStorageConfig(mode=DownsampledStorageConfig.MODE_NORMAL)
112112
if sampling_mode not in SAMPLING_MODE_MAP:
113113
raise InvalidSearchQuery(f"sampling mode: {sampling_mode} is not supported")
114114
else:

0 commit comments

Comments
 (0)