"Unqualify `type`" code action does not show up in record declarations

[folospior]

Reproduction code:

• wibble.gleam:

pub type Wibble

• wobble.gleam:

import wibble

pub type Wobble {
  Wobble(wibble: wibble.Wibble)
  //             ^^^^^^^^^^^^^
}

Highlighting on the marked area and running the Show code actions LSP command shows no available code actions.

Gleam 1.10.0 from Nixpkgs

[lpil]

Thank you

[cysabi]

hi! i'm a new contributor, wanted to try tackling this issue :)

i found my way to

gleam/compiler-core/src/language_server/engine.rs

Line 392 in 3db41fd

code_action_convert_unqualified_constructor_to_qualified(

which seems to be the right spot?

going to try to figure this out but would love some tips!

[GearsDatapacks]

Yeah! Except you're looking at unqualified_to_qualified, the code action in question here is the one above, qualified_to_unqualified.
You'll need to look at how it is implemented and make changes inside the code_action module.

Actually, that depends on where the bug is. I suspect the issue might lie in the fact that the AST visitor is still not 100% implemented, so you might need to edit that.

[cysabi]

thank you!!

for the ast visitor, do u mean this?

gleam/compiler-core/src/language_server/code_action.rs

Line 3830 in 3db41fd

fn visit_typed_custom_type(&mut self, custom_type: &'ast ast::TypedCustomType) {

[GearsDatapacks]

That's what one implementation of the ast visitor looks like, yes. Though I think you may need to modify the actual definition of it, in the ast::visit module.

[cysabi]

hi! thank you so much taking the time to explain stuff ~ i might be lost again 😭

i tried to do cysabi@9b86e8a which did not work

i tried finding some other places to look and i found some comments about Record Value Constructor which im not sure i quite understand what it's referring to, and of which happens here:

gleam/compiler-core/src/language_server/code_action.rs

Line 1445 in 25e55a6

fn visit_typed_expr_module_select(

which led to

gleam/compiler-core/src/ast/visit.rs

Line 1030 in 25e55a6

pub fn visit_typed_expr_module_select<'a, V>(

which does have a todo comment? but im not sure if that's the issue

i also know that there's impl's in

gleam/compiler-core/src/language_server/code_action.rs

Line 1131 in 25e55a6

impl<'ast> ast::visit::Visit<'ast> for AddAnnotations<'_> {

and tried playing around with impl a visit_typed_custom_type in there, also no avail

im sure im missing something obvious, thank you in advance!

[GearsDatapacks]

Your commit seems like the correct way to go, at least that's where I would have started. At this point, I would probably just sprinkle in a handful of dbg! macros and try to figure out where it's going wrong.

[cysabi]

okay! sent a pr #4595

just as an fyi, it turns out my fix did work, i just did not know haha. got super confused about how the snapshot runner worked as ive never done something like this before, a couple lines in the contributing about installing insta and using the review tool would be my suggestion!

[GearsDatapacks]

A couple lines in the contributing about installing insta and using the review tool would be my suggestion!

You mean something like this?

[cysabi]

omg i missed this sorry!!