Merge pull request #1 from spiegel-im-spiegel/fix-bugs

Modified error handling

Author: spiegel-im-spiegel

go.mod

@@ -4,6 +4,6 @@ go 1.13
 
 require (
 	github.com/spf13/cobra v0.0.5
-	github.com/spiegel-im-spiegel/errs v0.2.1
+	github.com/spiegel-im-spiegel/errs v0.2.2
 	github.com/spiegel-im-spiegel/gocli v0.10.1
 )

go.sum

@@ -22,8 +22,8 @@ github.com/spf13/jwalterweatherman v1.0.0/go.mod h1:cQK4TGJAtQXfYWX+Ddv3mKDzgVb6
 github.com/spf13/pflag v1.0.3 h1:zPAT6CGy6wXeQ7NtTnaTerfKOsV6V6F8agHXFiazDkg=
 github.com/spf13/pflag v1.0.3/go.mod h1:DYY7MBk1bdzusC3SYhjObp+wFpr4gzcvqqNjLnInEg4=
 github.com/spf13/viper v1.3.2/go.mod h1:ZiWeW+zYFKm7srdB9IoDzzZXaJaI5eL9QjNiN/DMA2s=
-github.com/spiegel-im-spiegel/errs v0.2.1 h1:jyrtXGQ0A216ohQ46wQYd9BlXkOcvLhkHNMK/hJAcXc=
-github.com/spiegel-im-spiegel/errs v0.2.1/go.mod h1:NwHSe6m3oAhRj2bAkkbzz9xAffIDNcP9uTdyJd9fJNs=
+github.com/spiegel-im-spiegel/errs v0.2.2 h1:ltRYJzh2Vn59HfySjQCex1vOji/dH0xJV6jyzBCeClg=
+github.com/spiegel-im-spiegel/errs v0.2.2/go.mod h1:NwHSe6m3oAhRj2bAkkbzz9xAffIDNcP9uTdyJd9fJNs=
 github.com/spiegel-im-spiegel/gocli v0.10.1 h1:XWyq4dKFp2xTjiH2P2bxPZyi0++4IHp9HOksgGdfwpA=
 github.com/spiegel-im-spiegel/gocli v0.10.1/go.mod h1:9vRvly2giutJ2sAtQjrw570p9ulJA3twgKlurmnj12g=
 github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=

values-date.go

@@ -1,7 +1,7 @@
 package openbd
 
 import (
-	"fmt"
+	"strconv"
 	"strings"
 	"time"
 
@@ -34,7 +34,10 @@ var timeTemplate3 = []string{
 
 //UnmarshalJSON returns result of Unmarshal for json.Unmarshal()
 func (t *Date) UnmarshalJSON(b []byte) error {
-	s := strings.Trim(string(b), "\"")
+	s := string(b)
+	if ss, err := strconv.Unquote(s); err == nil {
+		s = ss
+	}
 	if len(s) == 0 || strings.ToLower(s) == "null" {
 		*t = Date{time.Time{}}
 		return nil
@@ -44,44 +47,41 @@ func (t *Date) UnmarshalJSON(b []byte) error {
 		if strings.Contains(s, ":") {
 			for _, tmplt := range timeTemplate1 {
 				if tm, err := time.Parse(tmplt, s); err != nil {
-					lastErr = err
+					lastErr = errs.Wrap(err, "", errs.WithParam("time_string", s), errs.WithParam("time_template", tmplt))
 				} else {
 					*t = Date{tm}
 					return nil
 				}
 			}
-			return errs.Wrap(lastErr, "error in Date.UnmarshalJSON() function")
+			return lastErr
 		}
 		for _, tmplt := range timeTemplate2 {
 			if tm, err := time.Parse(tmplt, s); err != nil {
-				lastErr = err
+				lastErr = errs.Wrap(err, "", errs.WithParam("time_string", s), errs.WithParam("time_template", tmplt))
 			} else {
 				*t = Date{tm}
 				return nil
 			}
 		}
-		return errs.Wrap(lastErr, "error in Date.UnmarshalJSON() function")
+		return lastErr
 	}
 	for _, tmplt := range timeTemplate3 {
 		if tm, err := time.Parse(tmplt, s); err != nil {
-			lastErr = err
+			lastErr = errs.Wrap(err, "", errs.WithParam("time_string", s), errs.WithParam("time_template", tmplt))
 		} else {
 			*t = Date{tm}
 			return nil
 		}
 	}
-	return errs.Wrap(lastErr, "error in Date.UnmarshalJSON() function")
+	return lastErr
 }
 
 //MarshalJSON returns time string with RFC3339 format
 func (t *Date) MarshalJSON() ([]byte, error) {
-	if t == nil {
-		return []byte("\"\""), nil
-	}
-	if t.IsZero() {
+	if t == nil || t.IsZero() {
 		return []byte("\"\""), nil
 	}
-	return []byte(fmt.Sprintf("\"%v\"", t)), nil
+	return []byte(strconv.Quote(t.String())), nil
 }
 
 func (t Date) String() string {

values-date_test.go

@@ -51,12 +51,18 @@ func TestUnmarshal(t *testing.T) {
 }
 
 func TestUnmarshalErr(t *testing.T) {
-	data := `{"date_taken": "2005/03/26"}`
-	tst := &ForTestStruct{}
-	if err := json.Unmarshal([]byte(data), tst); err == nil {
-		t.Error("Unmarshal() error = nil, not want nil.")
-	} else {
-		fmt.Printf("Info: %+v\n", err)
+	testCases := []string{
+		`{"date_taken": "2005/03/26"}`,
+		`{"date_taken": "2005-03-26 00:00"}`,
+		`{"date_taken": "2005-03-26+0900"}`,
+	}
+	for _, tcStr := range testCases {
+		tst := &ForTestStruct{}
+		if err := json.Unmarshal([]byte(tcStr), tst); err == nil {
+			t.Error("Unmarshal() error = nil, not want nil.")
+		} else {
+			fmt.Printf("Info: %+v\n", err)
+		}
 	}
 }