Implemented set_time_left in Timer node. If new time_left is bigger than wait_time, sets wait_time value

Author: jeronimo-schreyer

doc/classes/Timer.xml

@@ -58,9 +58,9 @@
 		<member name="process_callback" type="int" setter="set_timer_process_callback" getter="get_timer_process_callback" enum="Timer.TimerProcessCallback" default="1">
 			Specifies when the timer is updated during the main loop.
 		</member>
-		<member name="time_left" type="float" setter="" getter="get_time_left">
+		<member name="time_left" type="float" setter="set_time_left" getter="get_time_left">
 			The timer's remaining time in seconds. This is always [code]0[/code] if the timer is stopped.
-			[b]Note:[/b] This property is read-only and cannot be modified. It is based on [member wait_time].
+			[b]Note:[/b] Setting this property when the timer is stopped pushes a warning message.
 		</member>
 		<member name="wait_time" type="float" setter="set_wait_time" getter="get_wait_time" default="1.0">
 			The time required for the timer to end, in seconds. This property can also be set every time [method start] is called.

scene/main/timer.cpp

@@ -158,6 +158,13 @@ double Timer::get_time_left() const {
 	return time_left > 0 ? time_left : 0;
 }
 
+void Timer::set_time_left(double p_time_left) {
+	if (!processing) {
+		ERR_FAIL_COND_MSG(!processing, vformat("Setting time_left when the timer is stopped. Use start(time_left) to start automatically"));
+	}
+	time_left = p_time_left > wait_time ? wait_time : p_time_left;
+}
+
 void Timer::set_timer_process_callback(TimerProcessCallback p_callback) {
 	if (timer_process_callback == p_callback) {
 		return;
@@ -228,6 +235,7 @@ void Timer::_bind_methods() {
 	ClassDB::bind_method(D_METHOD("is_stopped"), &Timer::is_stopped);
 
 	ClassDB::bind_method(D_METHOD("get_time_left"), &Timer::get_time_left);
+	ClassDB::bind_method(D_METHOD("set_time_left", "time_left"), &Timer::set_time_left);
 
 	ClassDB::bind_method(D_METHOD("set_timer_process_callback", "callback"), &Timer::set_timer_process_callback);
 	ClassDB::bind_method(D_METHOD("get_timer_process_callback"), &Timer::get_timer_process_callback);
@@ -240,7 +248,7 @@ void Timer::_bind_methods() {
 	ADD_PROPERTY(PropertyInfo(Variant::BOOL, "autostart"), "set_autostart", "has_autostart");
 	ADD_PROPERTY(PropertyInfo(Variant::BOOL, "paused", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NONE), "set_paused", "is_paused");
 	ADD_PROPERTY(PropertyInfo(Variant::BOOL, "ignore_time_scale"), "set_ignore_time_scale", "is_ignoring_time_scale");
-	ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "time_left", PROPERTY_HINT_NONE, "suffix:s", PROPERTY_USAGE_NONE), "", "get_time_left");
+	ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "time_left", PROPERTY_HINT_NONE, "suffix:s", PROPERTY_USAGE_NONE), "set_time_left", "get_time_left");
 
 	BIND_ENUM_CONSTANT(TIMER_PROCESS_PHYSICS);
 	BIND_ENUM_CONSTANT(TIMER_PROCESS_IDLE);

scene/main/timer.h

@@ -75,6 +75,7 @@ class Timer : public Node {
 	bool is_stopped() const;
 
 	double get_time_left() const;
+	void set_time_left(double p_time_left);
 
 	PackedStringArray get_configuration_warnings() const override;