Reduce cgroups read frequency to avoid kernel kernfs clock pressure

xigang · xigang · commit 766f729f6a21 · 2024-12-08T10:29:13.000+08:00
Signed-off-by: xigang &lt;wangxigang2014@gmail.com&gt;
diff --git a/manager/manager.go b/manager/manager.go
@@ -541,8 +541,10 @@ func (m *manager) GetContainerInfoV2(containerName string, options v2.RequestOpt
 }
 
 func (m *manager) containerDataToContainerInfo(cont *containerData, query *info.ContainerInfoRequest) (*info.ContainerInfo, error) {
-	// Get the info from the container.
-	cinfo, err := cont.GetInfo(true)
+	// Get the info from the container. When GetInfo is set to false,
+	// it reads cgroups once every 5 seconds and gets data from containerData cache at other times,
+	// reducing the frequency of reading cgroups to avoid kernel kernfs clock pressure that could cause Linux machine to hang
+	cinfo, err := cont.GetInfo(false)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -541,8 +541,10 @@ func (m *manager) GetContainerInfoV2(containerName string, options v2.RequestOpt`
`541`	`541`	`}`
`542`	`542`
`543`	`543`	`func (m manager) containerDataToContainerInfo(cont containerData, query info.ContainerInfoRequest) (info.ContainerInfo, error) {`
`544`		`- // Get the info from the container.`
`545`		`- cinfo, err := cont.GetInfo(true)`
	`544`	`+ // Get the info from the container. When GetInfo is set to false,`
	`545`	`+ // it reads cgroups once every 5 seconds and gets data from containerData cache at other times,`
	`546`	`+ // reducing the frequency of reading cgroups to avoid kernel kernfs clock pressure that could cause Linux machine to hang`
	`547`	`+ cinfo, err := cont.GetInfo(false)`
`546`	`548`	`if err != nil {`
`547`	`549`	`return nil, err`
`548`	`550`	`}`